Sign upLogin

betagouv/service-national-universel

View on GitHub
Star
api/src/utils/cohort.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function getPlaces has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

async function getPlaces(sessions, region) {
  const cohorts = await CohortModel.find({});
  const sessionNames = sessions.map(({ name }) => name);
  const goals = await InscriptionGoalModel.aggregate([{ $match: { region, cohort: { $in: sessionNames } } }, { $group: { _id: "$cohort", total: { $sum: "$max" } } }]);
  const agg = await YoungModel.aggregate([
Severity: Minor
Found in api/src/utils/cohort.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getFilteredSessions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

async function getFilteredSessions(young, timeZoneOffset = "") {
  const cohorts = await CohortModel.find({});
  const region = getRegionForEligibility(young);
  const department = getDepartmentForEligibility(young);
Severity: Minor
Found in api/src/utils/cohort.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status