Sign upLogin

betajs/betajs-data

View on GitHub
Star
src/data/queries/query_engine.js

Summary

Maintainability
D
1 day
Test Coverage

Function compileIndexQuery has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        compileIndexQuery: function(constrainedDNFQuery, key, index) {
            var fullQuery = Objs.exists(constrainedDNFQuery.query.$or, function(query) {
                return !(key in query);
            });
            var primaryKeySort = constrainedDNFQuery.options.sort && Objs.ithKey(constrainedDNFQuery.options.sort, 0) === key;
Severity: Major
Found in src/data/queries/query_engine.js - About 3 hrs to fix

    File query_engine.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    Scoped.define("module:Queries.Engine", [
    "module:Queries",
    "module:Queries.Constrained",
    "base:Strings",
    "base:Types",
    Severity: Minor
    Found in src/data/queries/query_engine.js - About 2 hrs to fix

      Function compileQuery has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              compileQuery: function(constrainedQuery, constrainedQueryCapabilities, constrainedQueryFunction, constrainedQueryContext) {
            constrainedQuery = Constrained.rectify(constrainedQuery);
            var sorting_supported = Constrained.sortValidate(constrainedQuery.options, constrainedQueryCapabilities);
            var query_supported = Queries.validate(constrainedQuery.query, constrainedQueryCapabilities.query || {});
            var skip_supported = Constrained.skipValidate(constrainedQuery.options, constrainedQueryCapabilities);
      Severity: Minor
      Found in src/data/queries/query_engine.js - About 1 hr to fix

        Function indexQueryConditionsSize has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                indexQueryConditionsSize: function(conds, index, ignoreCase) {
            var postfix = ignoreCase ? "_ic" : "";
            var info = index.info();
            var subSize = info.row_count;
            var rows_per_key = info.row_count / Math.max(info["key_count" + postfix], 1);
        Severity: Minor
        Found in src/data/queries/query_engine.js - About 1 hr to fix

          Function compileIndexedQuery has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  compileIndexedQuery: function(constrainedQuery, constrainedQueryCapabilities, constrainedQueryFunction, constrainedQueryContext, indices) {
            constrainedQuery = Constrained.rectify(constrainedQuery);
            indices = indices || {};
            if (this.queryPartially(constrainedQuery, constrainedQueryCapabilities) || Types.is_empty(indices))
                return this.compileQuery(constrainedQuery, constrainedQueryCapabilities, constrainedQueryFunction, constrainedQueryContext);
          Severity: Minor
          Found in src/data/queries/query_engine.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                            if (Math.sign((index.comparator())(currentKey, lastKey)) === Math.sign(primarySortDirection))
                                    return null;
            Severity: Major
            Found in src/data/queries/query_engine.js - About 45 mins to fix

              Function compileIndexedQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      compileIndexedQuery: function(constrainedQuery, constrainedQueryCapabilities, constrainedQueryFunction, constrainedQueryContext, indices) {
              Severity: Minor
              Found in src/data/queries/query_engine.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                if (conds.$lt || conds.$lte) {
                    l = conds.$lt || conds.$lte;
                    if (conds.$lt)
                        keys--;
                }
                Severity: Minor
                Found in src/data/queries/query_engine.js and 1 other location - About 50 mins to fix
                src/data/queries/query_engine.js on lines 32..36

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                if (conds.$gt || conds.$gte) {
                    g = conds.$gt || conds.$gte;
                    if (conds.$gt)
                        keys--;
                }
                Severity: Minor
                Found in src/data/queries/query_engine.js and 1 other location - About 50 mins to fix
                src/data/queries/query_engine.js on lines 38..42

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status