Sign upLogin

betajs/betajs-data

View on GitHub
Star
src/data/stores/delegators/contextualized_store.js

Summary

Maintainability
C
1 day
Test Coverage

File contextualized_store.js has 367 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Scoped.define("module:Stores.ContextualizedStore", [
    "module:Stores.BaseStore",
    "base:Iterators.MappedIterator"
], function (BaseStore, MappedIterator, scoped) {
    return BaseStore.extend({scoped: scoped}, function (inherited) {
Severity: Minor
Found in src/data/stores/delegators/contextualized_store.js - About 4 hrs to fix

    Function _updated has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                _updated: function (row, data, ctx, pre_data, transaction_id) {
    Severity: Minor
    Found in src/data/stores/delegators/contextualized_store.js - About 35 mins to fix

      Function _undecodedUpdated has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  _undecodedUpdated: function (id, updatedData, ctx, row, transaction_id) {
      Severity: Minor
      Found in src/data/stores/delegators/contextualized_store.js - About 35 mins to fix

        Function _undecodedUpdated has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                    _undecodedUpdated: function (id, updatedData, ctx, row, transaction_id) {},
        Severity: Minor
        Found in src/data/stores/delegators/contextualized_store.js - About 35 mins to fix

          TODO found
          Open

                              // TODO: This currently only works with MongoDB databases
          Severity: Minor
          Found in src/data/stores/delegators/contextualized_store.js by fixme

          TODO found
          Open

                                  // TODO: This is a weird workaround, otherwise the result will be empty
          Severity: Minor
          Found in src/data/stores/delegators/contextualized_store.js by fixme

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      _insert: function (data) {
                var decoded = this._decode(data);
                return this.__store.insert(decoded.data, decoded.ctx).mapSuccess(function (data) {
                    return this._encode(data, decoded.ctx);
                }, this);
          Severity: Major
          Found in src/data/stores/delegators/contextualized_store.js and 1 other location - About 2 hrs to fix
          src/data/stores/delegators/contextualized_store.js on lines 54..59

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 81.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      _get: function (id) {
                var decoded = this._decodeId(id);
                return this.__store.get(decoded.id, decoded.ctx).mapSuccess(function (data) {
                    return this._encode(data, decoded.ctx);
                }, this);
          Severity: Major
          Found in src/data/stores/delegators/contextualized_store.js and 1 other location - About 2 hrs to fix
          src/data/stores/delegators/contextualized_store.js on lines 40..45

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 81.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          return this._rawQuery(query, options, ctx).mapSuccess(function (results) {
                    return (new MappedIterator(results, function (row) {
                        return this._decodeRow(row, ctx);
                    }, this)).auto_destroy(results, true);
                }, this);
          Severity: Minor
          Found in src/data/stores/delegators/contextualized_store.js and 1 other location - About 30 mins to fix
          src/modelling/tables.js on lines 150..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status