Sign upLogin

betajs/betajs-data

View on GitHub
Star
src/data/stores/partial/partial_store_write_strategies.js

Summary

Maintainability
C
1 day
Test Coverage

File partial_store_write_strategies.js has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Scoped.define("module:Stores.PartialStoreWriteStrategies.WriteStrategy", [
                                                                          "base:Class"
                                                                          ], function (Class, scoped) {
    return Class.extend({scoped: scoped}, function (inherited) {
        return {
Severity: Minor
Found in src/data/stores/partial/partial_store_write_strategies.js - About 3 hrs to fix

    Function push has 78 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                push: function () {
                if (this.pushing)
                    return Promise.value(true);
                var failedIds = {};
                var unlockIds = {};
    Severity: Major
    Found in src/data/stores/partial/partial_store_write_strategies.js - About 3 hrs to fix

      Function next has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                          var next = function () {
                        if (!iter.hasNext()) {
                            iter.destroy();
                            this.pushing = false;
                            this.storeHistory.unlockCommits();
      Severity: Major
      Found in src/data/stores/partial/partial_store_write_strategies.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            return this.partialStore.cachedStore.cacheUpdate(cachedId, merger, {
                        ignoreLock: false,
                        lockAttrs: false,
                        silent: true,
                        refreshMeta: true,
        Severity: Minor
        Found in src/data/stores/partial/partial_store_write_strategies.js and 1 other location - About 35 mins to fix
        src/data/stores/partial/partial_store_write_strategies.js on lines 128..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            var promise = this.partialStore.cachedStore.cacheUpdate(cachedId, data, {
                        lockAttrs: true,
                        ignoreLock: false,
                        silent: true,
                        refreshMeta: false,
        Severity: Minor
        Found in src/data/stores/partial/partial_store_write_strategies.js and 1 other location - About 35 mins to fix
        src/data/stores/partial/partial_store_write_strategies.js on lines 54..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status