Sign upLogin

betajs/betajs-media-components

View on GitHub
Star
src/ads/ima/manager.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function onAdsManagerLoaded has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            onAdsManagerLoaded: function(adsManagerLoadedEvent) {
                const adsRenderingSettings = new google.ima.AdsRenderingSettings();
                if (this._options && this._options.adsRenderingSettings) {
                    for (let setting in this._options.adsRenderingSettings) {
                        if (setting === "uiElements") {
Severity: Minor
Found in src/ads/ima/manager.js - About 1 hr to fix

    Function __events has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                __events: function() {
                return [
                    google.ima.AdErrorEvent.Type.AD_ERROR,
                    google.ima.AdEvent.Type.AD_CAN_PLAY,
                    google.ima.AdEvent.Type.IMPRESSION,
    Severity: Minor
    Found in src/ads/ima/manager.js - About 1 hr to fix

      Function _setIMASettings has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  _setIMASettings: function(options) {
                const settings = options.IMASettings;
                // google.ima.ImaSdkSettings.VpaidMode.DISABLED
                // DISABLED == 0 - VPAID ads will not play, and an error will be returned.
                // ENABLED == 1 - VPAID ads are enabled using a cross-domain iframe
      Severity: Minor
      Found in src/ads/ima/manager.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                        if (uiElements.length >= 0) {
                                    adsRenderingSettings[setting] = uiElements;
                                }
        Severity: Major
        Found in src/ads/ima/manager.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          this._adsLoader.addEventListener(google.ima.AdErrorEvent.Type.AD_ERROR, this.onAdError.bind(this), false);
          Severity: Minor
          Found in src/ads/ima/manager.js and 1 other location - About 30 mins to fix
          src/ads/ima/manager.js on lines 26..26

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          this._adsLoader.addEventListener(google.ima.AdsManagerLoadedEvent.Type.ADS_MANAGER_LOADED, this.onAdsManagerLoaded.bind(this), false);
          Severity: Minor
          Found in src/ads/ima/manager.js and 1 other location - About 30 mins to fix
          src/ads/ima/manager.js on lines 25..25

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status