betajs/betajs-media-components

View on GitHub
src/dynamics/video_recorder/chooser/chooser.js

Summary

Maintainability
D
2 days
Test Coverage

Function create has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

                create: function() {
                    var custom_accept_string = "";
                    if (this.get("allowedextensions") && this.get("allowedextensions").length > 0) {
                        var browser_support = Info.isEdge() || Info.isChrome() || Info.isOpera() || (Info.isFirefox() && Info.firefoxVersion() >= 42) || (Info.isInternetExplorer() && Info.internetExplorerVersion() >= 10);
                        if (browser_support)
Severity: Major
Found in src/dynamics/video_recorder/chooser/chooser.js - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                        if (this.get("allowedextensions") && this.get("allowedextensions").length > 0) {
                            var browser_support = Info.isEdge() || Info.isChrome() || Info.isOpera() || (Info.isFirefox() && Info.firefoxVersion() >= 42) || (Info.isInternetExplorer() && Info.internetExplorerVersion() >= 10);
                            if (browser_support)
                                custom_accept_string = "." + this.get("allowedextensions").join(",.");
                        } else if (!this.get("allowcustomupload")) {
    Severity: Critical
    Found in src/dynamics/video_recorder/chooser/chooser.js - About 1 hr to fix

      Function click_action has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                          click_action: function(action) {
                              if (action.get("select"))
                                  return;
                              if (action.get("type") === "screen" || action.get("type") === "multistream") {
                                  this.trigger("record-screen", action.get("type") === "multistream");
      Severity: Minor
      Found in src/dynamics/video_recorder/chooser/chooser.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                if (Info.isMobile() && Info.isCordova()) {
                                    var self = this;
                                    if (Info.isAndroid()) {
                                        navigator.device.capture.captureVideo(function(mediaFiles) {
                                            self.trigger("upload", mediaFiles[0]);
        Severity: Major
        Found in src/dynamics/video_recorder/chooser/chooser.js and 1 other location - About 1 day to fix
        src/dynamics/audio_recorder/chooser/chooser.js on lines 93..115

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 233.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (this.get("primaryrecord")) {
                                if (this.get("allowrecord"))
                                    order.push("record");
                                if (this.get("allowscreen"))
                                    order.push("screen");
        Severity: Major
        Found in src/dynamics/video_recorder/chooser/chooser.js and 1 other location - About 3 hrs to fix
        src/dynamics/video_recorder/chooser/chooser.js on lines 70..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            } else {
                                if (this.get("allowscreen"))
                                    order.push("screen");
                                if (this.get("allowupload"))
                                    order.push("upload");
        Severity: Major
        Found in src/dynamics/video_recorder/chooser/chooser.js and 1 other location - About 3 hrs to fix
        src/dynamics/video_recorder/chooser/chooser.js on lines 61..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                            select_file_action: function(action, domEvent) {
                                if (!action.get("select"))
                                    return;
                                this.trigger("upload", domEvent[0].target);
                            },
        Severity: Minor
        Found in src/dynamics/video_recorder/chooser/chooser.js and 2 other locations - About 35 mins to fix
        src/dynamics/audio_recorder/chooser/chooser.js on lines 118..122
        src/dynamics/image_capture/chooser/chooser.js on lines 116..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                    case "screen":
                                        actions.add({
                                            type: "screen",
                                            index: index,
                                            icon: "television",
        Severity: Minor
        Found in src/dynamics/video_recorder/chooser/chooser.js and 1 other location - About 30 mins to fix
        src/dynamics/video_recorder/chooser/chooser.js on lines 116..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                    case "multistream":
                                        actions.add({
                                            type: "multistream",
                                            index: index,
                                            icon: "plus",
        Severity: Minor
        Found in src/dynamics/video_recorder/chooser/chooser.js and 1 other location - About 30 mins to fix
        src/dynamics/video_recorder/chooser/chooser.js on lines 108..115

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status