Sign upLogin

betajs/betajs-ui

View on GitHub
Star
src/interactions/drag.js

Summary

Maintainability
C
1 day
Test Coverage

File drag.js has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Scoped.define("module:Interactions.Drag", [
    "module:Interactions.ElementInteraction",
    "module:Elements.ElementModifier",
    "browser:Dom",
    "module:Events.Support",
Severity: Minor
Found in src/interactions/drag.js - About 3 hrs to fix

    Function _start has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _start: function() {

            var parentElement = this.parent()._element;

            this._initial_element_coords = {
    Severity: Major
    Found in src/interactions/drag.js - About 2 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  if (this.options().classes && this.options().classes["move.actionable_modifier"])
                this.parent().actionable_modifier().csscls(this.options().classes["move.actionable_modifier"], true);
      Severity: Major
      Found in src/interactions/drag.js and 2 other locations - About 2 hrs to fix
      src/interactions/drag.js on lines 320..321
      src/interactions/drop.js on lines 139..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  if (this.options().classes && this.options().classes["move.modifier"])
                this.parent().modifier().csscls(this.options().classes["move.modifier"], true);
      Severity: Major
      Found in src/interactions/drag.js and 2 other locations - About 2 hrs to fix
      src/interactions/drag.js on lines 318..319
      src/interactions/drop.js on lines 139..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  destroy: function() {
                this._modifier.revert();
                this._modifier.destroy();
                inherited.destroy.call(this);
            },
      Severity: Minor
      Found in src/interactions/drag.js and 1 other location - About 55 mins to fix
      src/interactions/drop.js on lines 37..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status