Sign upLogin

binary-com/binary-next-gen

View on GitHub
Star

Showing 389 of 551 total issues

Similar blocks of code found in 20 locations. Consider refactoring.
Open

export default class DigitStatsContainer extends PureComponent {

    render() {
        return (
            <DigitStatsCard {...immutableChildrenToJS(this.props)} />
Severity: Major
Found in src/digit-stats/DigitStatsContainer.js and 19 other locations - About 35 mins to fix
src/asset-details/AssetDetailsContainer.js on lines 8..15
src/asset-index/AssetIndexContainer.js on lines 9..16
src/asset-picker/AssetPickerContainer.js on lines 9..16
src/asset-picker/MarketSubmarketPickerContainer.js on lines 8..15
src/balance/BalanceContainer.js on lines 8..15
src/daily-prices/DailyPricesContainer.js on lines 9..16
src/examine-asset/ExamineAssetContainer.js on lines 8..15
src/layout-picker/LayoutPickerContainer.js on lines 8..15
src/portfolio/PortfolioContainer.js on lines 8..15
src/reality-check/RealityCheckContainer.js on lines 8..16
src/set-currency/SetCurrencyContainer.js on lines 8..16
src/settings/SettingsContainer.js on lines 8..15
src/statement/StatementContainer.js on lines 8..13
src/trading-times/TradingTimesContainer.js on lines 8..17
src/upgrade/UpgradeContainer.js on lines 8..16
src/user-accounts/UserAccountsContainer.js on lines 8..15
src/web/ClockContainer.js on lines 8..15
src/web/ToggleButtonsContainer.js on lines 9..16
src/workspace/WorkspaceContainer.js on lines 8..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

export default class TradingTimesContainer extends PureComponent {

    render() {
        return (
            <TradingTimesCard
Severity: Major
Found in src/trading-times/TradingTimesContainer.js and 19 other locations - About 35 mins to fix
src/asset-details/AssetDetailsContainer.js on lines 8..15
src/asset-index/AssetIndexContainer.js on lines 9..16
src/asset-picker/AssetPickerContainer.js on lines 9..16
src/asset-picker/MarketSubmarketPickerContainer.js on lines 8..15
src/balance/BalanceContainer.js on lines 8..15
src/daily-prices/DailyPricesContainer.js on lines 9..16
src/digit-stats/DigitStatsContainer.js on lines 8..15
src/examine-asset/ExamineAssetContainer.js on lines 8..15
src/layout-picker/LayoutPickerContainer.js on lines 8..15
src/portfolio/PortfolioContainer.js on lines 8..15
src/reality-check/RealityCheckContainer.js on lines 8..16
src/set-currency/SetCurrencyContainer.js on lines 8..16
src/settings/SettingsContainer.js on lines 8..15
src/statement/StatementContainer.js on lines 8..13
src/upgrade/UpgradeContainer.js on lines 8..16
src/user-accounts/UserAccountsContainer.js on lines 8..15
src/web/ClockContainer.js on lines 8..15
src/web/ToggleButtonsContainer.js on lines 9..16
src/workspace/WorkspaceContainer.js on lines 8..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

export default class MarketSubmarketPickerContainer extends PureComponent {

    render() {
        return (
            <MarketSubmarketPicker {...immutableChildrenToJS(this.props)} />
Severity: Major
Found in src/asset-picker/MarketSubmarketPickerContainer.js and 19 other locations - About 35 mins to fix
src/asset-details/AssetDetailsContainer.js on lines 8..15
src/asset-index/AssetIndexContainer.js on lines 9..16
src/asset-picker/AssetPickerContainer.js on lines 9..16
src/balance/BalanceContainer.js on lines 8..15
src/daily-prices/DailyPricesContainer.js on lines 9..16
src/digit-stats/DigitStatsContainer.js on lines 8..15
src/examine-asset/ExamineAssetContainer.js on lines 8..15
src/layout-picker/LayoutPickerContainer.js on lines 8..15
src/portfolio/PortfolioContainer.js on lines 8..15
src/reality-check/RealityCheckContainer.js on lines 8..16
src/set-currency/SetCurrencyContainer.js on lines 8..16
src/settings/SettingsContainer.js on lines 8..15
src/statement/StatementContainer.js on lines 8..13
src/trading-times/TradingTimesContainer.js on lines 8..17
src/upgrade/UpgradeContainer.js on lines 8..16
src/user-accounts/UserAccountsContainer.js on lines 8..15
src/web/ClockContainer.js on lines 8..15
src/web/ToggleButtonsContainer.js on lines 9..16
src/workspace/WorkspaceContainer.js on lines 8..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

export default class PortfolioContainer extends PureComponent {

    render() {
        return (
            <PortfolioCard {...immutableChildrenToJS(this.props)} />
Severity: Major
Found in src/portfolio/PortfolioContainer.js and 19 other locations - About 35 mins to fix
src/asset-details/AssetDetailsContainer.js on lines 8..15
src/asset-index/AssetIndexContainer.js on lines 9..16
src/asset-picker/AssetPickerContainer.js on lines 9..16
src/asset-picker/MarketSubmarketPickerContainer.js on lines 8..15
src/balance/BalanceContainer.js on lines 8..15
src/daily-prices/DailyPricesContainer.js on lines 9..16
src/digit-stats/DigitStatsContainer.js on lines 8..15
src/examine-asset/ExamineAssetContainer.js on lines 8..15
src/layout-picker/LayoutPickerContainer.js on lines 8..15
src/reality-check/RealityCheckContainer.js on lines 8..16
src/set-currency/SetCurrencyContainer.js on lines 8..16
src/settings/SettingsContainer.js on lines 8..15
src/statement/StatementContainer.js on lines 8..13
src/trading-times/TradingTimesContainer.js on lines 8..17
src/upgrade/UpgradeContainer.js on lines 8..16
src/user-accounts/UserAccountsContainer.js on lines 8..15
src/web/ClockContainer.js on lines 8..15
src/web/ToggleButtonsContainer.js on lines 9..16
src/workspace/WorkspaceContainer.js on lines 8..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      presence: () => {
        if (/MF/i.test(props.loginid)) {
          return {
            presence: true,
            message: 'This field is required.',
Severity: Minor
Found in src/settings/SettingsUserInformation.validation.config.js and 1 other location - About 35 mins to fix
src/settings/SettingsUserInformation.validation.config.js on lines 38..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    & (<T1, T2, T3, T4, T5, Y, R, N, Fn: Saga5<Y, R, N, T1, T2, T3, T4, T5>>(saga: Fn, t1: T1, t2: T2, t3: T3, t4: T4, t5: T5, ...rest: Array<void>) => Task)
Severity: Minor
Found in flow-typed/npm/redux-saga_v0.11.x.js and 1 other location - About 30 mins to fix
flow-typed/npm/redux-saga_v0.11.x.js on lines 105..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

type ConnectMergedStateless = <P, SP, DP, MP, Dispatch: Function>(
  mapStateToProps: (state: Object, ownProps: $Diff<P, MP>) => SP,
  mapDispatchToProps: (dispatch: Dispatch, ownProps: $Diff<P, MP>) => DP,
  mergeProps: (stateProps: SP, dispatchProps: DP, ownProps: $Diff<P, MP>) => MP,
  options?: {pure?: boolean, withRef?: boolean}
Severity: Minor
Found in flow-typed/npm/react-redux_v4.x.x.js and 1 other location - About 30 mins to fix
flow-typed/npm/react-redux_v4.x.x.js on lines 40..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

type ConnectNoStateStatless = <P, DP, Dispatch: Function>(
    mapStateToProps: null | void,
    mapDispatchToProps: (dispatch: Dispatch, ownProps: $Diff<P, DP>) => DP,
    mergeProps: null | void,
    options?: {pure?: boolean, withRef?: boolean}
Severity: Minor
Found in flow-typed/npm/react-redux_v4.x.x.js and 1 other location - About 30 mins to fix
flow-typed/npm/react-redux_v4.x.x.js on lines 26..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

     & (<T1, T2, T3, T4, T5, Y, R, N, Fn: Saga5<Y, R, N, T1, T2, T3, T4, T5>>(pattern: Pattern, saga: Fn, t1: T1, t2: T2, t3: T3, t4: T4, t5: T5, ...rest: Array<void>) => TakeXRet)
Severity: Minor
Found in flow-typed/npm/redux-saga_v0.11.x.js and 1 other location - About 30 mins to fix
flow-typed/npm/redux-saga_v0.11.x.js on lines 138..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language