binary-com/binary-next-gen

View on GitHub
src/_reducers/trades/TradesProposalInfoReducer.js

Summary

Maintainability
C
7 hrs
Test Coverage

Avoid too many return statements within this function.
Open

            return initialState;
Severity: Major
Found in src/_reducers/trades/TradesProposalInfoReducer.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return state;
    Severity: Major
    Found in src/_reducers/trades/TradesProposalInfoReducer.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return state.setIn([entry[0], 'proposal'], action.serverResponse.proposal);
      Severity: Major
      Found in src/_reducers/trades/TradesProposalInfoReducer.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return state;
        Severity: Major
        Found in src/_reducers/trades/TradesProposalInfoReducer.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return state.remove(action.index);
          Severity: Major
          Found in src/_reducers/trades/TradesProposalInfoReducer.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return initialState;
            Severity: Major
            Found in src/_reducers/trades/TradesProposalInfoReducer.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return state.setIn([index, fieldName], fieldValue);
              Severity: Major
              Found in src/_reducers/trades/TradesProposalInfoReducer.js - About 30 mins to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        case CHANGE_ACTIVE_LAYOUT: {
                            const oldTradesCount = state.size;
                            const newTradesCount = action.tradesCount;
                            const countDiff = newTradesCount - oldTradesCount;
                
                
                Severity: Major
                Found in src/_reducers/trades/TradesProposalInfoReducer.js and 3 other locations - About 3 hrs to fix
                src/_reducers/trades/TradesErrorReducer.js on lines 24..39
                src/_reducers/trades/TradesPurchaseInfoReducer.js on lines 17..33
                src/_reducers/trades/TradesUIStateReducer.js on lines 17..32

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                        case REMOVE_TRADE: {
                            if (!state.get(action.index)) {
                                return state;
                            }
                            return state.remove(action.index);
                Severity: Major
                Found in src/_reducers/trades/TradesProposalInfoReducer.js and 4 other locations - About 35 mins to fix
                src/_reducers/trades/TradesErrorReducer.js on lines 43..48
                src/_reducers/trades/TradesParamsReducer.js on lines 108..113
                src/_reducers/trades/TradesPurchaseInfoReducer.js on lines 49..54
                src/_reducers/trades/TradesUIStateReducer.js on lines 36..41

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status