binary-com/binary-next-gen

View on GitHub
src/settings/__tests__/settingsSelfExclusion-test.js

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('Timeout until date should be before 6 weeks later', () => {
    const wrapper = mountWithIntl(<SettingsSelfExclusion />);
    const timeoutUntilDate = wrapper.find('#timeout_until_date').hostNodes();
    timeoutUntilDate.instance().value = dateFormat(moment().add(6, 'weeks').add(1, 'days'));
    wrapper.update();
Severity: Major
Found in src/settings/__tests__/settingsSelfExclusion-test.js and 2 other locations - About 5 hrs to fix
src/settings/__tests__/settingsSelfExclusion-test.js on lines 163..172
src/settings/__tests__/settingsSelfExclusion-test.js on lines 174..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 154.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('Exclude time cannot be less than 6 months and should have error.', () => {
    const wrapper = mountWithIntl(<SettingsSelfExclusion />);
    const excludeUntil = wrapper.find('#exclude_until').hostNodes();
    excludeUntil.instance().value = dateFormat(moment().add(6, 'months').subtract(1, 'days'));
    wrapper.update();
Severity: Major
Found in src/settings/__tests__/settingsSelfExclusion-test.js and 2 other locations - About 5 hrs to fix
src/settings/__tests__/settingsSelfExclusion-test.js on lines 92..101
src/settings/__tests__/settingsSelfExclusion-test.js on lines 174..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 154.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('Exclude time cannot be more than 5 years and should have error.', () => {
    const wrapper = mountWithIntl(<SettingsSelfExclusion />);
    const excludeUntil = wrapper.find('#exclude_until').hostNodes();
    excludeUntil.instance().value = dateFormat(moment().add(5, 'years').add(1, 'days'));
    wrapper.update();
Severity: Major
Found in src/settings/__tests__/settingsSelfExclusion-test.js and 2 other locations - About 5 hrs to fix
src/settings/__tests__/settingsSelfExclusion-test.js on lines 92..101
src/settings/__tests__/settingsSelfExclusion-test.js on lines 163..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 154.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('Timeout until date should be after moment', () => {
    const wrapper = mountWithIntl(<SettingsSelfExclusion />);
    const timeoutUntilDate = wrapper.find('#timeout_until_date').hostNodes();
    timeoutUntilDate.instance().value = dateFormat(moment().subtract(1, 'days'));
    wrapper.update();
Severity: Major
Found in src/settings/__tests__/settingsSelfExclusion-test.js and 1 other location - About 5 hrs to fix
src/settings/__tests__/settingsSelfExclusion-test.js on lines 141..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it('Timeout until time should be required when timeout until date is filled', () => {
    const wrapper = mountWithIntl(<SettingsSelfExclusion />);
    const timeoutUntilDate = wrapper.find('#timeout_until_date').hostNodes();
    timeoutUntilDate.instance().value = dateFormat(moment().add(1, 'days'));
    wrapper.update();
Severity: Major
Found in src/settings/__tests__/settingsSelfExclusion-test.js and 1 other location - About 5 hrs to fix
src/settings/__tests__/settingsSelfExclusion-test.js on lines 81..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status