Showing 18 of 20 total issues
Method view
has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring. Open
def view
cache_this!
@entry = CatalogEntry.find_by!(name: params[:name], tag: params[:tag])
@data = @entry.api_data
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File catalog_entry.rb
has 364 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'mixlib/versioning'
class CatalogEntry < ActiveRecord::Base
validates_presence_of :type
validates :name, :tag, presence: true,
Method configure_admin
has 106 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.configure_admin(klass)
klass.rails_admin do
label klass.to_s.demodulize.titleize
navigation_label I18n.t 'app.nav.catalog'
object_label_method do
Class CatalogEntry
has 29 methods (exceeds 20 allowed). Consider refactoring. Open
class CatalogEntry < ActiveRecord::Base
validates_presence_of :type
validates :name, :tag, presence: true,
format: {with: /\A[a-z0-9][a-z0-9_\.-]+[a-z0-9]\z/i, message: 'allows letters, numbers, hyphens, underscores, and full-stops.'}
validates :tag, uniqueness: {scope: :name}
Method refresh!
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
def refresh!
begin
v = check_remote_version
unless v.kind_of?(FalseClass)
if (v.kind_of?(String) and not v.empty?) or (v.kind_of?(Hash) and not v[:version].to_s.empty?)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method output
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def self.output(options, data)
data_out = data
unless data_out.is_a? Exception
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method view
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
def view
cache_this!
@entry = CatalogEntry.find_by!(name: params[:name], tag: params[:tag])
@data = @entry.api_data
Method refresh!
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def refresh!
begin
v = check_remote_version
unless v.kind_of?(FalseClass)
if (v.kind_of?(String) and not v.empty?) or (v.kind_of?(Hash) and not v[:version].to_s.empty?)
Method output
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.output(options, data)
data_out = data
unless data_out.is_a? Exception
Method update
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def update
index
Instance.transaction do
@instances.each do |i|
k = "ver_#{i.id}".to_sym
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_remote_version
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def check_remote_version
text = fetch_remote_text
iexp = Regexp.new(include_regex.to_s)
xexp = Regexp.new(exclude_regex.to_s)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method fetch_remote_text
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def fetch_remote_text
url = web_page_url.to_s.gsub(/%(?!\{)/, '%%') % template_params
text = open(url) { |f| f.read }
unless [css_query, xpath_query].all? { |v| v.to_s.empty? }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
if (v.kind_of?(String) and not v.empty?) or (v.kind_of?(Hash) and not v[:version].to_s.empty?)
v0 = version.presence
v1 = std_version(v.kind_of?(Hash) && v[:version] || v)
CatalogEntry.transaction do
Method api
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def api
cache_this!
# Attempt to use latest values for examples.
begin
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method gem_version
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def gem_version(name, filter=nil)
versions = Gems.versions(name)
raise 'Failed to retrieve gem info.' unless versions
raise versions.to_s unless versions.is_a?(Array)
if filter
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_remote_version
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def check_remote_version
case tag
when /jdk[0-9]|jre[0-9]/
raise "Unknown Java tag (#{tag})" unless vendor_urls.include?(tag)
major = scan_number(tag)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method templated
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def templated(name)
template = self.send(name)
template = template.to_s.gsub(/%(?!\{)/, '%%')
params = template_params
counter = 0
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method match_requirement
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def match_requirement(list, requirement)
cache = Hash.new
list = list.map do |y|
begin
scan_version_cache(y, cache, true)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"