Sign upLogin

binhonglee/GlobeTrotte

View on GitHub
Star

Showing 25 of 49 total issues

Function updateDay has 6 return statements (exceeds 4 allowed).
Open

func updateDay(
    updatedDay *wings.Day, createOnNonExist bool,
) bool {
    existingDay := fetchDay(int64(updatedDay.ID))
    if updatedDay.ID == -1 || existingDay.ID != updatedDay.ID {
Severity: Major
Found in src/turbine/database/tripdb.go - About 40 mins to fix

    Function addTest has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        path string,
    t *testing.T,
    toAdd structs.IStructs,
    objType interface{},
    unmarshalBody bool,
    Severity: Minor
    Found in src/turbine/router/router_test.go - About 35 mins to fix

      Function updateTest has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          path string,
    t *testing.T,
    toAdd structs.IStructs,
    objType interface{},
    expectedCode int,
      Severity: Minor
      Found in src/turbine/router/router_test.go - About 35 mins to fix

        Function getModuleInfo has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func getModuleInfo(name string, gmod *golistobj) gopkg {
    var mod golistobj
    if gmod == nil {
        res := runNoPanic("go", "list", "--json", name)
        if len(res) == 0 {
        Severity: Minor
        Found in src/turbine/scripts/genBUILD.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getRoute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          private getRoute(path: string, name: string, component: string): string {
    let metaTxt = "";
    for (const key of Object.keys(meta)) {
      if (
        meta[key].includes(name) ||
        Severity: Minor
        Found in src/cockpit/scripts/genRouter.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language