bitovi/canjs

View on GitHub
docs/can-guides/commitment/recipes/credit-card-advanced/8-pay-button.js

Summary

Maintainability
F
4 days
Test Coverage

File 8-pay-button.js has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { kefir as Kefir, StacheElement } from "//unpkg.com/can@6/ecosystem.mjs";

class CCPayment extends StacheElement {
  static view = `
    <form on:submit="this.pay(scope.event)">

    Function showOnlyWhenBlurredOnce has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      showOnlyWhenBlurredOnce(errorStream, blurredStream) {
        const errorEvent = errorStream.map(error => {
          if (!error) {
            return {
              type: "valid"

      Function showOnlyWhenBlurredOnce has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        showOnlyWhenBlurredOnce(errorStream, blurredStream) {
          const errorEvent = errorStream.map(error => {
            if (!error) {
              return {
                type: "valid"
      Severity: Minor
      Found in docs/can-guides/commitment/recipes/credit-card-advanced/8-pay-button.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 6 locations. Consider refactoring.
      Open

        showOnlyWhenBlurredOnce(errorStream, blurredStream) {
          const errorEvent = errorStream.map(error => {
            if (!error) {
              return {
                type: "valid"
      docs/can-guides/commitment/recipes/credit-card-advanced/4-card-blur.js on lines 71..130
      docs/can-guides/commitment/recipes/credit-card-advanced/5-expiry.js on lines 123..182
      docs/can-guides/commitment/recipes/credit-card-advanced/6-cvc.js on lines 167..226
      docs/can-guides/commitment/recipes/credit-card-advanced/7-disable-pay.js on lines 178..237
      docs/can-guides/commitment/recipes/credit-card-advanced/9-disable-payments.js on lines 262..321

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 301.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          get paymentStatusStream() {
            return this.paymentPromises.map(promise => {
              if (promise) {
                // STREAM<STATUS>
                return Kefir.concat([
      docs/can-guides/commitment/recipes/credit-card-advanced/9-disable-payments.js on lines 178..200

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 128.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          get paymentPromises() {
            return Kefir.combine(
              [this.payClicked],
              [this.card],
              (payClicked, card) => {
      docs/can-guides/commitment/recipes/credit-card-advanced/9-disable-payments.js on lines 159..174

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

        validateExpiry(expiry) {
          if (!expiry) {
            return "There is no expiry. Format  MM-YY";
          }
          if (
      docs/can-guides/commitment/recipes/credit-card-advanced/5-expiry.js on lines 110..121
      docs/can-guides/commitment/recipes/credit-card-advanced/6-cvc.js on lines 142..153
      docs/can-guides/commitment/recipes/credit-card-advanced/7-disable-pay.js on lines 153..164
      docs/can-guides/commitment/recipes/credit-card-advanced/9-disable-payments.js on lines 237..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          get card() {
            return Kefir.combine(
              [this.cardNumber, this.expiry, this.cvc],
              (cardNumber, expiry, cvc) => {
                return { cardNumber, expiry, cvc };
      docs/can-guides/commitment/recipes/credit-card-advanced/9-disable-payments.js on lines 149..156

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          get isCardInvalid() {
            return Kefir.combine(
              [this.cardError, this.expiryError, this.cvcError],
              (cardError, expiryError, cvcError) => {
                return !!(cardError || expiryError || cvcError);
      docs/can-guides/commitment/recipes/credit-card-advanced/7-disable-pay.js on lines 134..141
      docs/can-guides/commitment/recipes/credit-card-advanced/9-disable-payments.js on lines 140..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

        validateCVC(cvc) {
          if (!cvc) {
            return "There is no CVC code";
          }
          if (cvc.length !== 3) {
      docs/can-guides/commitment/recipes/credit-card-advanced/7-disable-pay.js on lines 166..176
      docs/can-guides/commitment/recipes/credit-card-advanced/9-disable-payments.js on lines 250..260

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

          get expiry() {
            return this.userExpiry.map(expiry => {
              if (expiry) {
                return expiry.split("-");
              }
      docs/can-guides/commitment/recipes/credit-card-advanced/5-expiry.js on lines 81..87
      docs/can-guides/commitment/recipes/credit-card-advanced/6-cvc.js on lines 100..106
      docs/can-guides/commitment/recipes/credit-card-advanced/7-disable-pay.js on lines 102..108
      docs/can-guides/commitment/recipes/credit-card-advanced/9-disable-payments.js on lines 108..114

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 8 locations. Consider refactoring.
      Open

          get cardNumber() {
            return this.userCardNumber.map(card => {
              if (card) {
                return card.replace(/[\s-]/g, "");
              }
      docs/can-guides/commitment/recipes/credit-card-advanced/2-read-card.js on lines 33..39
      docs/can-guides/commitment/recipes/credit-card-advanced/3-card-error.js on lines 32..38
      docs/can-guides/commitment/recipes/credit-card-advanced/4-card-blur.js on lines 42..48
      docs/can-guides/commitment/recipes/credit-card-advanced/5-expiry.js on lines 61..67
      docs/can-guides/commitment/recipes/credit-card-advanced/6-cvc.js on lines 80..86
      docs/can-guides/commitment/recipes/credit-card-advanced/7-disable-pay.js on lines 82..88
      docs/can-guides/commitment/recipes/credit-card-advanced/9-disable-payments.js on lines 88..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status