Sign upLogin

bkdotcom/HttpMessage

View on GitHub
Star

Showing 5 of 6 total issues

ServerRequest has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class ServerRequest extends Request implements ServerRequestInterface
{
    /** @var array */
    private $attributes = array();
Severity: Minor
Found in src/HttpMessage/ServerRequest.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

            return $base
            ->withPath(self::pathRemoveDots($targetPath))
            ->withQuery($rel->getQuery())
            ->withFragment($rel->getFragment());
    Severity: Major
    Found in src/HttpMessage/Utility/Uri.php - About 30 mins to fix

      Function assertQueryParams has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function assertQueryParams(array $get): void
    {
        $iterator = new RecursiveIteratorIterator(
            new RecursiveArrayIterator($get),
            RecursiveIteratorIterator::SELF_FIRST
      Severity: Minor
      Found in src/HttpMessage/AssertionTrait.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function filesFromGlobals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function filesFromGlobals(array $phpFiles, array $path = []): array
    {
        $files = array();
        /** @var mixed $value */
        foreach ($phpFiles as $key => $value) {
      Severity: Minor
      Found in src/HttpMessage/Utility/ServerRequest.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function pathRemoveDots has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function pathRemoveDots(string $path): string
    {
        if ($path === '') {
            return '';
        }
      Severity: Minor
      Found in src/HttpMessage/Utility/Uri.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language