bnomei/kirby3-bolt

View on GitHub

Showing 2 of 2 total issues

Function findByID has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Open

    public function findByID(string $id): ?Page
    {
        $page = $this->lookup($id);
        if ($page) {
            return $page;
Severity: Minor
Found in classes/Bolt.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method findByID has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function findByID(string $id): ?Page
    {
        $page = $this->lookup($id);
        if ($page) {
            return $page;
Severity: Major
Found in classes/Bolt.php - About 3 hrs to fix
    Severity
    Category
    Status
    Source
    Language