Sign upLogin

bnomei/kirby3-lapse

View on GitHub
Star

Showing 6 of 6 total issues

Function keyFromObject has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function keyFromObject($key): string
    {
        if (is_string($key)) {
            return $key;
        }
Severity: Minor
Found in classes/Lapse.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method keyFromObject has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function keyFromObject($key): string
    {
        if (is_string($key)) {
            return $key;
        }
Severity: Minor
Found in classes/Lapse.php - About 1 hr to fix

    Function getAndSetIfMissingOrExpired has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getAndSetIfMissingOrExpired($key, $value = null, $expires = null)
    {
        if ($this->option('debug')) {
            try {
                return $this->serialize($value);
    Severity: Minor
    Found in classes/Lapse.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $response;
    Severity: Major
    Found in classes/Lapse.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return strval($key);
      Severity: Major
      Found in classes/Lapse.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $key->key() . hash('xxh3', $key->value());
        Severity: Major
        Found in classes/Lapse.php - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language