bnomei/kirby3-robots-txt

View on GitHub

Showing 7 of 7 total issues

Function addGroups has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private function addGroups($groups = null): Robotstxt
    {
        if (! $groups) {
            return $this;
        }
Severity: Minor
Found in classes/Robotstxt.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addSitemap has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function addSitemap($sitemap = null): Robotstxt
    {
        // @codeCoverageIgnoreStart
        if (option('omz13.xmlsitemap.disable') === false) {
            $this->txt[] = 'sitemap: ' . url('/sitemap.xml');
Severity: Minor
Found in classes/Robotstxt.php - About 1 hr to fix

    Function addSitemap has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function addSitemap($sitemap = null): Robotstxt
        {
            // @codeCoverageIgnoreStart
            if (option('omz13.xmlsitemap.disable') === false) {
                $this->txt[] = 'sitemap: ' . url('/sitemap.xml');
    Severity: Minor
    Found in classes/Robotstxt.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return $this;
    Severity: Major
    Found in classes/Robotstxt.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $this;
      Severity: Major
      Found in classes/Robotstxt.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return $this;
        Severity: Major
        Found in classes/Robotstxt.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $this;
          Severity: Major
          Found in classes/Robotstxt.php - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language