Sign upLogin

bokuweb/tsukiakari

View on GitHub
Star
src/renderer/src/components/tweet-window.js

Summary

Maintainability
B
5 hrs
Test Coverage

File tweet-window.js has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* @flow */

import React, { Component } from 'react';
import Window from 'react-window-component';
import B from '../lib/bem';
Severity: Minor
Found in src/renderer/src/components/tweet-window.js - About 2 hrs to fix

    Function render has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render(): ?React$Element<*> {
    // eslint-disable-next-line no-undef
    const remain = 140 - twttr.txt.getTweetLength(this.state.status);
    let buttonState;
    if (remain < 0 || remain === 140) buttonState = 'isDisabled';
    Severity: Minor
    Found in src/renderer/src/components/tweet-window.js - About 1 hr to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

        shouldComponentUpdate(nextProps: Props, nextState: State): bool {
    return !isEqual(this.props, nextProps) || !isEqual(this.state, nextState);
  }
      Severity: Major
      Found in src/renderer/src/components/tweet-window.js and 2 other locations - About 1 hr to fix
      src/renderer/src/components/account-list.js on lines 20..22
      src/renderer/src/components/add-column-menu.js on lines 105..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status