Sign upLogin

bokuweb/tuna_pasta

View on GitHub
Star
src/reducers/feed.js

Summary

Maintainability
F
3 days
Test Coverage

Function feed has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

export default function feed(state={}, action) {
  let elementHeight;
  switch(action.type){
    case types.INITIALIZING :
      state.isInitialized = false;
Severity: Minor
Found in src/reducers/feed.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function feed has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function feed(state={}, action) {
  let elementHeight;
  switch(action.type){
    case types.INITIALIZING :
      state.isInitialized = false;
Severity: Major
Found in src/reducers/feed.js - About 4 hrs to fix

    Avoid too many return statements within this function.
    Open

          return Object.assign({}, state);
    Severity: Major
    Found in src/reducers/feed.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return Object.assign({}, state);
      Severity: Major
      Found in src/reducers/feed.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return Object.assign({}, state);
        Severity: Major
        Found in src/reducers/feed.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return Object.assign({}, state);
          Severity: Major
          Found in src/reducers/feed.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return Object.assign({}, state);
            Severity: Major
            Found in src/reducers/feed.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return Object.assign({}, state);
              Severity: Major
              Found in src/reducers/feed.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return Object.assign({}, state);
                Severity: Major
                Found in src/reducers/feed.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return Object.assign({}, state);
                  Severity: Major
                  Found in src/reducers/feed.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return Object.assign({}, state);
                    Severity: Major
                    Found in src/reducers/feed.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return Object.assign({}, state);
                      Severity: Major
                      Found in src/reducers/feed.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return Object.assign({}, state);
                        Severity: Major
                        Found in src/reducers/feed.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return Object.assign({}, state);
                          Severity: Major
                          Found in src/reducers/feed.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return Object.assign({}, state);
                            Severity: Major
                            Found in src/reducers/feed.js - About 30 mins to fix

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                  case types.CLOSE_COMMENT :
      state[action.keyword].items = _.map(state[action.keyword].items, item => {
        if (item.link === action.link) item.isCommentOpen = false;
        return item;
      });
                              Severity: Major
                              Found in src/reducers/feed.js and 2 other locations - About 3 hrs to fix
                              src/reducers/feed.js on lines 120..125
                              src/reducers/feed.js on lines 138..143

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 97.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                  case types.FETCHING_COMMENT :
      state[action.keyword].items = _.map(state[action.keyword].items, item => {
        if (item.link === action.link) item.isCommentFetching = true;
        return item;
      });
                              Severity: Major
                              Found in src/reducers/feed.js and 2 other locations - About 3 hrs to fix
                              src/reducers/feed.js on lines 138..143
                              src/reducers/feed.js on lines 145..150

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 97.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 3 locations. Consider refactoring.
                              Open

                                  case types.CLOSE_COMMENT :
      state[action.keyword].items = _.map(state[action.keyword].items, item => {
        if (item.link === action.link) item.isCommentOpen = false;
        return item;
      });
                              Severity: Major
                              Found in src/reducers/feed.js and 2 other locations - About 3 hrs to fix
                              src/reducers/feed.js on lines 120..125
                              src/reducers/feed.js on lines 145..150

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 97.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if (state.all.elementHeight.length > 0)
          state.all.elementHeight = state.all.elementHeight.concat(elementHeight);
        else
          state.all.elementHeight = elementHeight;
                              Severity: Major
                              Found in src/reducers/feed.js and 1 other location - About 1 hr to fix
                              src/reducers/feed.js on lines 87..90

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 67.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if (state[keyword].elementHeight.length > 0)
          state[keyword].elementHeight = state[keyword].elementHeight.concat(elementHeight);
        else
          state[keyword].elementHeight = elementHeight;
                              Severity: Major
                              Found in src/reducers/feed.js and 1 other location - About 1 hr to fix
                              src/reducers/feed.js on lines 83..86

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 67.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status