Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/client/components/pages/parts/add-entity-to-collection-modal.js

Summary

Maintainability
D
1 day
Test Coverage

Function render has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        if (this.state.entities.length === 0) {
            this.handleAddEntity();
        }
Severity: Major
Found in src/client/components/pages/parts/add-entity-to-collection-modal.js - About 3 hrs to fix

    Function handleSubmit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        handleSubmit() {
        const cleanedEntities = this.getCleanedEntities();
        const bbids = cleanedEntities.map(entity => entity.id);
        if (bbids.length) {
            request.post(`/collection/${this.props.collectionId}/add`)
    Severity: Minor
    Found in src/client/components/pages/parts/add-entity-to-collection-modal.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          handleChangeEntity(newEnt, index) {
        let newEntity;
        if (!newEnt) {
            newEntity = {
                id: null,
      Severity: Major
      Found in src/client/components/pages/parts/add-entity-to-collection-modal.js and 1 other location - About 3 hrs to fix
      src/client/components/forms/userCollection.js on lines 119..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      AddEntityToCollectionModal.propTypes = {
    closeModalAndShowMessage: PropTypes.func.isRequired,
    collectionId: PropTypes.string.isRequired,
    collectionType: PropTypes.string.isRequired,
    onCloseModal: PropTypes.func.isRequired,
      Severity: Major
      Found in src/client/components/pages/parts/add-entity-to-collection-modal.js and 2 other locations - About 2 hrs to fix
      src/client/components/pages/parts/privs-edit-modal.js on lines 179..185
      src/client/entity-editor/submission-section/submission-section.js on lines 120..126

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 77.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      const buttonAfter = (
                                    <Button
                                        size="sm"
                                        type="button"
                                        variant="danger"
      Severity: Major
      Found in src/client/components/pages/parts/add-entity-to-collection-modal.js and 1 other location - About 1 hr to fix
      src/client/components/forms/userCollection.js on lines 265..274

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          handleRemoveEntity(index) {
        this.setState(prevState => ({
            entities: prevState.entities.splice(index, 1) && prevState.entities
        }));
    }
      Severity: Minor
      Found in src/client/components/pages/parts/add-entity-to-collection-modal.js and 1 other location - About 50 mins to fix
      src/client/components/forms/userCollection.js on lines 113..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          handleAddEntity() {
        this.setState(prevState => ({
            entities: [...prevState.entities, {id: null, name: ''}]
        }));
    }
      Severity: Minor
      Found in src/client/components/pages/parts/add-entity-to-collection-modal.js and 1 other location - About 40 mins to fix
      src/client/components/forms/userCollection.js on lines 107..111

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status