Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/client/entity-editor/name-section/name-section.js

Summary

Maintainability
C
1 day
Test Coverage

Function render has 116 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const {
            disambiguationDefaultValue,
            entityType,
            exactMatches: immutableExactMatches,
Severity: Major
Found in src/client/entity-editor/name-section/name-section.js - About 4 hrs to fix

    File name-section.js has 306 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (C) 2016  Ben Ockmore
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
    Severity: Minor
    Found in src/client/entity-editor/name-section/name-section.js - About 3 hrs to fix

      Function renderDuplicateAlert has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          renderDuplicateAlert(warnIfExists, disambiguationDefaultValue, exactMatches, entityType, lgCol) {
        return (
            <Col lg={lgCol}>
                {isRequiredDisambiguationEmpty(
                    warnIfExists,
      Severity: Minor
      Found in src/client/entity-editor/name-section/name-section.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                const {
            disambiguationDefaultValue,
            entityType,
            exactMatches: immutableExactMatches,
            languageOptions,
        Severity: Major
        Found in src/client/entity-editor/name-section/name-section.js and 1 other location - About 1 hr to fix
        src/server/helpers/achievement.js on lines 620..634

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            <Col lg={lgCol}>
                        <SortNameField
                            defaultValue={sortNameValue}
                            empty={isAliasEmpty(
                                nameValue, sortNameValue, languageValue
        Severity: Major
        Found in src/client/entity-editor/name-section/name-section.js and 1 other location - About 1 hr to fix
        src/client/entity-editor/alias-editor/alias-row.js on lines 91..101

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status