bookbrainz/bookbrainz-site

View on GitHub
src/client/entity-editor/validators/date.js

Summary

Maintainability
C
1 day
Test Coverage

Function dateValidator has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

export function dateValidator(dayObj, monthObj, yearObj) {
    const year = Number.parseInt(yearObj, 10);
    const month = Number.parseInt(monthObj, 10);
    const day = Number.parseInt(dayObj, 10);

Severity: Minor
Found in src/client/entity-editor/validators/date.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dateValidator has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function dateValidator(dayObj, monthObj, yearObj) {
    const year = Number.parseInt(yearObj, 10);
    const month = Number.parseInt(monthObj, 10);
    const day = Number.parseInt(dayObj, 10);

Severity: Minor
Found in src/client/entity-editor/validators/date.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

            return {errorMessage: 'Month is not valid', isValid: false};
    Severity: Major
    Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return {errorMessage: 'Day is not valid', isValid: false};
      Severity: Major
      Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return {errorMessage: 'Day is not valid for this month', isValid: false};
        Severity: Major
        Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return {errorMessage: 'Year is not leap, invalid day', isValid: false};
          Severity: Major
          Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return {errorMessage: 'Month is not valid', isValid: false};
            Severity: Major
            Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return {errorMessage: '', isValid: true};
              Severity: Major
              Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return {errorMessage: 'Day is not valid for this month', isValid: false};
                Severity: Major
                Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return {errorMessage: 'Month must be entered if day is entered', isValid: false};
                  Severity: Major
                  Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return {errorMessage: '', isValid: true};
                    Severity: Major
                    Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return {errorMessage: 'Day is not valid', isValid: false};
                      Severity: Major
                      Found in src/client/entity-editor/validators/date.js - About 30 mins to fix

                        There are no issues that match your filters.

                        Category
                        Status