Sign upLogin

bookbrainz/bookbrainz-site

View on GitHub
Star
src/server/helpers/achievement.js

Summary

Maintainability
F
4 days
Test Coverage

File achievement.js has 481 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright (C) 2016  Max Prettyjohns
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
Severity: Minor
Found in src/server/helpers/achievement.js - About 7 hrs to fix

    Function processEdit has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function processEdit(orm, userId, revisionId) {
    const revisionist = await processRevisionist(orm, userId);
    const authorCreator = await processAuthorCreator(orm, userId);
    const limitedEdition = await processLimitedEdition(orm, userId);
    const publisher = await processPublisher(orm, userId);
    Severity: Minor
    Found in src/server/helpers/achievement.js - About 1 hr to fix

      Function testTiers has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      async function testTiers(orm, signal, editorId, tiers) {
    const tierPromise = tiers.map(async (tier) => {
        if (signal >= tier.threshold) {
            try {
                const achievementUnlock = await awardAchievement(orm, editorId, tier.name);
      Severity: Minor
      Found in src/server/helpers/achievement.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function testTiers has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function testTiers(orm, signal, editorId, tiers) {
    const tierPromise = tiers.map(async (tier) => {
        if (signal >= tier.threshold) {
            try {
                const achievementUnlock = await awardAchievement(orm, editorId, tier.name);
      Severity: Minor
      Found in src/server/helpers/achievement.js - About 1 hr to fix

        Function awardTitle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        async function awardTitle(orm, editorId, tier) {
    const {TitleType, TitleUnlock} = orm;
    if (tier.titleName) {
        const title = await new TitleType({title: tier.titleName})
            .fetch({require: false});
        Severity: Minor
        Found in src/server/helpers/achievement.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        async function processPublisherCreator(orm, editorId) {
    const {PublisherRevision} = orm;
    const rowCount = await getTypeCreation(new PublisherRevision(),
        'publisher_revision',
        editorId);
        Severity: Major
        Found in src/server/helpers/achievement.js and 5 other locations - About 3 hrs to fix
        src/server/helpers/achievement.js on lines 238..257
        src/server/helpers/achievement.js on lines 259..278
        src/server/helpers/achievement.js on lines 280..301
        src/server/helpers/achievement.js on lines 326..347
        src/server/helpers/achievement.js on lines 349..370

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        async function processPublisher(orm, editorId) {
    const {EditionGroupRevision} = orm;
    const rowCount = await getTypeCreation(new EditionGroupRevision(),
        'edition_group_revision',
        editorId);
        Severity: Major
        Found in src/server/helpers/achievement.js and 5 other locations - About 3 hrs to fix
        src/server/helpers/achievement.js on lines 238..257
        src/server/helpers/achievement.js on lines 259..278
        src/server/helpers/achievement.js on lines 303..324
        src/server/helpers/achievement.js on lines 326..347
        src/server/helpers/achievement.js on lines 349..370

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        async function processSeriesCreator(orm, editorId) {
    const {SeriesRevision} = orm;
    const rowCount = await getTypeCreation(new SeriesRevision(),
        'series_revision',
        editorId);
        Severity: Major
        Found in src/server/helpers/achievement.js and 5 other locations - About 3 hrs to fix
        src/server/helpers/achievement.js on lines 238..257
        src/server/helpers/achievement.js on lines 259..278
        src/server/helpers/achievement.js on lines 280..301
        src/server/helpers/achievement.js on lines 303..324
        src/server/helpers/achievement.js on lines 326..347

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        async function processLimitedEdition(orm, editorId) {
    const {EditionRevision} = orm;
    const rowCount = await getTypeCreation(new EditionRevision(), 'edition_revision', editorId);
    const tiers = [
        {
        Severity: Major
        Found in src/server/helpers/achievement.js and 5 other locations - About 3 hrs to fix
        src/server/helpers/achievement.js on lines 238..257
        src/server/helpers/achievement.js on lines 280..301
        src/server/helpers/achievement.js on lines 303..324
        src/server/helpers/achievement.js on lines 326..347
        src/server/helpers/achievement.js on lines 349..370

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        async function processAuthorCreator(orm, editorId) {
    const {AuthorRevision} = orm;
    const rowCount = await getTypeCreation(new AuthorRevision(), 'author_revision', editorId);
    const tiers = [
        {
        Severity: Major
        Found in src/server/helpers/achievement.js and 5 other locations - About 3 hrs to fix
        src/server/helpers/achievement.js on lines 259..278
        src/server/helpers/achievement.js on lines 280..301
        src/server/helpers/achievement.js on lines 303..324
        src/server/helpers/achievement.js on lines 326..347
        src/server/helpers/achievement.js on lines 349..370

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

        async function processWorkerBee(orm, editorId) {
    const {WorkRevision} = orm;
    const rowCount = await getTypeCreation(new WorkRevision(),
        'work_revision',
        editorId);
        Severity: Major
        Found in src/server/helpers/achievement.js and 5 other locations - About 3 hrs to fix
        src/server/helpers/achievement.js on lines 238..257
        src/server/helpers/achievement.js on lines 259..278
        src/server/helpers/achievement.js on lines 280..301
        src/server/helpers/achievement.js on lines 303..324
        src/server/helpers/achievement.js on lines 349..370

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return {
        alert,
        authorCreator,
        funRunner,
        hotOffThePress,
        Severity: Major
        Found in src/server/helpers/achievement.js and 1 other location - About 1 hr to fix
        src/client/entity-editor/name-section/name-section.js on lines 171..185

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        async function processMarathoner(orm, editorId) {
    const rowCount = await getConsecutiveDaysWithEdits(orm, editorId, 29);
    const tiers = [{
        name: 'Marathoner',
        threshold: 30,
        Severity: Minor
        Found in src/server/helpers/achievement.js and 1 other location - About 55 mins to fix
        src/server/helpers/achievement.js on lines 419..429

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        async function processFunRunner(orm, editorId) {
    const rowCount = await getConsecutiveDaysWithEdits(orm, editorId, 6);
    const tiers = [
        {
            name: 'Fun Runner',
        Severity: Minor
        Found in src/server/helpers/achievement.js and 1 other location - About 55 mins to fix
        src/server/helpers/achievement.js on lines 431..439

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status