borgbackup/borg

View on GitHub

Showing 507 of 611 total issues

Function do_repo_list has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def do_repo_list(self, args, repository, manifest):
        """List the archives contained in a repository"""
        if args.format is not None:
            format = args.format
        elif args.short:
Severity: Minor
Found in src/borg/archiver/repo_list_cmd.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function analyze_change has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def analyze_change(self, base, new):
        """for each directory path, sum up the changed (removed or added) chunks' sizes between base and new."""

        def analyze_path_change(path):
            base_chunks = base[path]
Severity: Minor
Found in src/borg/archiver/analyze_cmd.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if not dry_run:
                            item.chunks = chunks  # TODO: overwrite? IDs and sizes are same.
                            archive.stats.nfiles += 1
                    if not dry_run:
Severity: Major
Found in src/borg/archiver/transfer_cmd.py - About 45 mins to fix

    Function get_repository has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def get_repository(
        location, *, create, exclusive, lock_wait, lock, append_only, make_parent_dirs, storage_quota, args, v1_or_v2
    ):
        if location.proto in ("ssh", "socket"):
            RemoteRepoCls = LegacyRemoteRepository if v1_or_v2 else RemoteRepository
    Severity: Minor
    Found in src/borg/archiver/_common.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function define_archive_filters_group has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def define_archive_filters_group(subparser, *, sort_by=True, first_last=True, oldest_newest=True, older_newer=True):
    Severity: Minor
    Found in src/borg/archiver/_common.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if not is_win32:
                              # The S_IFBLK macro is broken on MINGW
                              assert stat.S_ISBLK(item.mode)
                          # looks like we can't use os.major/minor with data coming from another platform,
                          # thus we only do a rather rough check here:
      Severity: Major
      Found in src/borg/testsuite/archiver/transfer_cmd_test.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if not recurse_excluded_dir:
                                        if keep_exclude_tags:
                                            if not dry_run:
                                                fso.process_dir_with_fd(
                                                    path=path, fd=child_fd, st=st, strip_prefix=strip_prefix
        Severity: Major
        Found in src/borg/archiver/create_cmd.py - About 45 mins to fix

          Function do_help has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def do_help(self, parser, commands, args):
                  if not args.topic:
                      parser.print_help()
                  elif args.topic in self.helptext:
                      print(rst_to_terminal(self.helptext[args.topic]))
          Severity: Minor
          Found in src/borg/archiver/help_cmd.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function fuse_mount has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def fuse_mount(archiver, mountpoint=None, *options, fork=True, os_fork=False, **kwargs):
          Severity: Minor
          Found in src/borg/testsuite/archiver/__init__.py - About 45 mins to fix

            Function print_warning has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def print_warning(self, msg, *args, **kw):
                    warning_code = kw.get("wc", EXIT_WARNING)  # note: wc=None can be used to not influence exit code
                    warning_type = kw.get("wt", "percent")
                    assert warning_type in ("percent", "curly")
                    warning_msgid = kw.get("msgid")
            Severity: Minor
            Found in src/borg/archiver/__init__.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function test_stats_progress has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def test_stats_progress(item_path, update_size, expected_output, stats, monkeypatch, columns=80):
            Severity: Minor
            Found in src/borg/testsuite/archive_test.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      for chunk_id, size in item.chunks:
                                          chunk_present = cache.seen_chunk(chunk_id, size)
                                          if not chunk_present:  # target repo does not yet have this chunk
                                              if not dry_run:
                                                  cdata = other_repository.get(chunk_id)
              Severity: Major
              Found in src/borg/archiver/transfer_cmd.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        for id, size in item.chunks_healthy:
                                            use_it(id, wanted=True)
                        pi.finish()
                Severity: Major
                Found in src/borg/archiver/compact_cmd.py - About 45 mins to fix

                  Function do_key_import has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def do_key_import(self, args, repository):
                          """Import the repository key from backup"""
                          manager = KeyManager(repository)
                          if args.paper:
                              if args.path:
                  Severity: Minor
                  Found in src/borg/archiver/key_cmds.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _import_tar has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def _import_tar(self, args, repository, manifest, key, cache, tarstream):
                  Severity: Minor
                  Found in src/borg/archiver/tar_cmds.py - About 45 mins to fix

                    Function parse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def parse(
                            self, id: bytes, cdata: bytes, decompress: bool = True, want_compressed: bool = False, ro_type: str = None
                        ) -> tuple[dict, bytes]:
                            """
                            Parse a repo object into metadata and data (decrypt it, maybe decompress, maybe verify if the chunk plaintext
                    Severity: Minor
                    Found in src/borg/repoobj.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function parse_inclexcl_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def parse_inclexcl_command(cmd_line_str, fallback=ShellPattern):
                        """Read a --patterns-from command from string and return a CmdTuple object."""
                    
                        cmd_prefix_map = {
                            "-": IECommand.Exclude,
                    Severity: Minor
                    Found in src/borg/patterns.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function test_remote_rpc_exception_transport has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def test_remote_rpc_exception_transport(remote_repository):
                        with remote_repository:
                            s1 = "test string"
                    
                            try:
                    Severity: Minor
                    Found in src/borg/testsuite/legacyrepository_test.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function write_chunkindex_to_repo_cache has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def write_chunkindex_to_repo_cache(repository, chunks, *, compact=False, clear=False, force_write=False):
                    Severity: Minor
                    Found in src/borg/cache.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          for seed in (1849058162, 1234567653):
                                              fh = BytesIO(data)
                                              chunker = Chunker(seed, minexp, maxexp, maskbits, winsize)
                                              chunks = [blake2b_256(b"", c) for c in cf(chunker.chunkify(fh, -1))]
                                              runs.append(blake2b_256(b"", b"".join(chunks)))
                      Severity: Major
                      Found in src/borg/testsuite/chunker_slow_test.py - About 45 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language