Showing 7 of 19 total issues
File FRITZBox.java has 262 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
* Copyright (c) 2018 - 2021 by Botorabi. All rights reserved.
* https://github.com/botorabi/HomieCenter
*
* License: MIT License (MIT), read the LICENSE text inMethod handleDeviceCommand has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void handleDeviceCommand(long deviceId, @NonNull final String command) throws Exception {
final String CMD_TEMPERATURE = "temperature=";
final String CMD_ON = "on";
final String CMD_OFF = "off";
Method get has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public ResponseEntity<String> get(@NonNull final String url, @Nullable final Map<String, String> parameters) throws Exception {
String finalUrl = url;
if (parameters != null) {
String params = "";
for (Map.Entry<String, String> entry : parameters.entrySet()) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method handleDeviceCommand has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public void handleDeviceCommand(long deviceId, @NonNull final String command) throws Exception {
final String CMD_TEMPERATURE = "temperature=";
final String CMD_ON = "on";
final String CMD_OFF = "off";
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method toString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
@Override
public String toString() {
String rightsString = "";
if (rights != null) {
for (Map.Entry<String, String> entry: rights.entrySet()) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method collectRights has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
private HashMap<String, String> collectRights(@NonNull final Node rightsNode) {
HashMap<String, String> rights = new HashMap<>();
Node nextNode = rightsNode.getFirstChild();
while(nextNode != null) {
nextNode = findNextSiblingNode(nextNode, "Name");- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method edit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
@PostMapping("/api/user/edit")
public ResponseEntity<HomieCenterUser> edit(@RequestBody ReqUserEdit userEdit, Authentication authentication) {
Optional<HomieCenterUser> storedUser = userRepository.findById(userEdit.getId());
if (!storedUser.isPresent()) {
return new ResponseEntity<>(HttpStatus.NOT_FOUND);- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"