botwillacceptanything/botwillacceptanything

View on GitHub
lib/voting/voting.js

Summary

Maintainability
C
1 day
Test Coverage

File voting.js has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

(function() {
    var define = require('amdefine')(module);

    var deps = [
        'lodash',
Severity: Minor
Found in lib/voting/voting.js - About 3 hrs to fix

    Function postVoteStarted has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          Voting.prototype.postVoteStarted = function postVoteStarted(pr) {
            var self = this;
    
            this.getVoteStartedComment(pr, function (err, comment) {
              if (err) { return console.error('error in postVoteStarted:', err); }
    Severity: Minor
    Found in lib/voting/voting.js - About 1 hr to fix

      Function mergePR has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            Voting.prototype.mergePR = function mergePR(pr, cb) {
              var self = this;
      
              gh.pullRequests.get({
                user: self.repo.user,
      Severity: Minor
      Found in lib/voting/voting.js - About 1 hr to fix

        Function closePR has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              Voting.prototype.closePR = function closePR(message, pr, cb) {
                var self = this;
        
                // message is optional
                if (typeof pr === 'function') {
        Severity: Minor
        Found in lib/voting/voting.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (score > 1) {
                        // I like this PR, let's vote for it!
                        gh.issues.createComment({
                          user: self.repo.user,
                          repo: self.repo.repo,
          Severity: Major
          Found in lib/voting/voting.js and 1 other location - About 1 hr to fix
          lib/voting/voting.js on lines 269..277

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      } else if (score < -1) {
                        // Ugh, this PR sucks, boooo!
                        gh.issues.createComment({
                          user: self.repo.user,
                          repo: self.repo.repo,
          Severity: Major
          Found in lib/voting/voting.js and 1 other location - About 1 hr to fix
          lib/voting/voting.js on lines 261..277

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (data.repository.name !== this.repo.repo ||
                      data.repository.owner.login !== this.repo.user) {
                    return;
                  }
          Severity: Major
          Found in lib/voting/voting.js and 1 other location - About 1 hr to fix
          lib/voting/voting.js on lines 117..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (data.repository.name !== this.repo.repo ||
                      data.repository.owner.login !== this.repo.user) {
                    return;
                  }
          Severity: Major
          Found in lib/voting/voting.js and 1 other location - About 1 hr to fix
          lib/voting/voting.js on lines 83..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status