Sign upLogin

brettweavnet/outliers

View on GitHub
Star

Showing 11 of 11 total issues

Class Collection has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Collection

    include Enumerable
    include Outliers::Verifications::Shared::Collection
Severity: Minor
Found in lib/outliers/collection.rb - About 2 hrs to fix

    Method process has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

          def process
        @options = { threads: 1, log_level: 'info' }

        option_parser.parse!
    Severity: Minor
    Found in lib/outliers/cli/process.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def process
        @options = { threads: 1, log_level: 'info' }

        option_parser.parse!
    Severity: Minor
    Found in lib/outliers/cli/process.rb - About 1 hr to fix

      Method post has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def post(result, key, url)
        uri = URI.parse url

        host = uri.host
        port = uri.port
      Severity: Minor
      Found in lib/outliers/handlers/outliers_api.rb - About 1 hr to fix

        Method ssl_certificates_valid? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                  def ssl_certificates_valid?(args)
            days = args
            pass = true

            logger.debug "Load Balancer '#{id}' has no certificates." unless certificates.any?
        Severity: Minor
        Found in lib/outliers/resources/aws/elb/load_balancer.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method verify has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def verify(name, arguments=nil)
      logger.debug "Verifying '#{name}'."

      name += "?" unless name =~ /^.*\?$/
        Severity: Minor
        Found in lib/outliers/collection.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method send_verification has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def send_verification(object, verification, arguments) 
      if object.method(verification).arity.zero?
        unless arguments.nil?
          raise Outliers::Exceptions::NoArgumentRequired.new "Verification '#{verification}' does not require an arguments."
        end
        Severity: Minor
        Found in lib/outliers/collection.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method filter_tag has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                  def filter_tag(value)
            tag_name  = value.split(':').first
            tag_value = value.split(':').last
            logger.info "Loading filter by tag '#{tag_name}' equals '#{tag_value}'."
            list.select do |r|
        Severity: Minor
        Found in lib/outliers/filters/aws/ec2/tags.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method filter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def filter(action, args)
      name  = args.keys.first
      value = args.fetch name

      unless self.public_methods.include? "filter_#{name}".to_sym
        Severity: Minor
        Found in lib/outliers/collection.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method no_public_objects? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                  def no_public_objects?
            passed = true
            
            logger.info "Validating #{objects.count} objects in '#{id}' are private."
        Severity: Minor
        Found in lib/outliers/resources/aws/s3/bucket.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method process_evaluations_in_dir has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def process_evaluations_in_dir
      files.each do |file|
        next if File.directory? file
        next if File.extname(file) != '.rb'
        logger.info "Processing '#{file}'."
        Severity: Minor
        Found in lib/outliers/run.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language