Sign upLogin

brokeyourbike/ocvalidate-action

View on GitHub
Star

Showing 6 of 10 total issues

Function run has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function run (): Promise<void> {
  try {
    const platform: string = os.platform()

    const opencoreVersion = core.getInput('opencore-version')
Severity: Minor
Found in src/action.ts - About 1 hr to fix

    Function findOpenCoreRelease has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function findOpenCoreRelease (octokit: Api, sha: string, isRelease: boolean): Promise<utils.IOpenCoreRelease> {
  const release = await octokit.rest.repos.getReleaseByTag({
    owner: OWNER,
    repo: REPO,
    tag: getTagName(sha)
    Severity: Minor
    Found in src/prerelease.ts - About 1 hr to fix

      Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function run (): Promise<void> {
  try {
    const platform: string = os.platform()

    const opencoreVersion = core.getInput('opencore-version')
      Severity: Minor
      Found in src/action.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function findOpenCoreRelease has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function findOpenCoreRelease (octokit: Api, sha: string, isRelease: boolean): Promise<utils.IOpenCoreRelease> {
  const release = await octokit.rest.repos.getReleaseByTag({
    owner: OWNER,
    repo: REPO,
    tag: getTagName(sha)
      Severity: Minor
      Found in src/prerelease.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function findLatestRelease has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      async function findLatestRelease (octokit: Api, opencoreVersion: string): Promise<utils.IOpenCoreRelease> {
  let opencore: utils.IOpenCoreRelease

  const commitsSha = await release.getLatestCommitsSha(octokit)
  for (const commitSha of commitsSha) {
      Severity: Minor
      Found in src/action.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function download has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function download (opencore: IOpenCoreRelease, platform: string): Promise<IOcvalidateVersionFile> {
  try {
    core.info(`Acquiring OpenCore ${opencore.version} from ${opencore.downloadUrl}`)
    const downloadPath = await tc.downloadTool(opencore.downloadUrl)
      Severity: Minor
      Found in src/utils.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language