bronycub/sugarcub

View on GitHub
core/static/vendor/jquery-expander/test/tests.js

Summary

Maintainability
D
2 days
Test Coverage

File tests.js has 372 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*global module:false, test:false, equal:false, ok:false, asyncTest:false,start:false, expect: false */

/* SINGLE BLOCK BASICS */
module('single block', {
  setup: function() {
Severity: Minor
Found in core/static/vendor/jquery-expander/test/tests.js - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    test('preserve numbers as words', function() {
      equal(this.preserveNumbers.find('.details').length, 1, 'created detail');
    
      this.preserveNumbers.find('.read-more, .details').remove();
    
    
    Severity: Major
    Found in core/static/vendor/jquery-expander/test/tests.js and 1 other location - About 2 hrs to fix
    core/static/vendor/jquery-expander/test/tests.js on lines 420..426

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    test('single long string, no child elements', function() {
      equal(this.zzz.find('.details').length, 1, 'created detail');
    
      this.zzz.find('.read-more, .details').remove();
    
    
    Severity: Major
    Found in core/static/vendor/jquery-expander/test/tests.js and 1 other location - About 2 hrs to fix
    core/static/vendor/jquery-expander/test/tests.js on lines 457..463

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      dds.each(function(index) {
        var txtLength = $.trim($(this).text()).length;
        var slicePoint = index === dds.length - 1 ? 92 : 100;
    
        equal(txtLength, slicePoint, msg(index, txtLength));
    Severity: Major
    Found in core/static/vendor/jquery-expander/test/tests.js and 2 other locations - About 2 hrs to fix
    core/static/vendor/jquery-expander/test/tests.js on lines 53..58
    core/static/vendor/jquery-expander/test/tests.js on lines 69..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      dds.each(function(index) {
        var txtLength = $.trim($(this).text()).length;
        var slicePoint = index === dds.length - 1 ? 92 : 200;
    
        equal(txtLength, slicePoint, msg(index, txtLength));
    Severity: Major
    Found in core/static/vendor/jquery-expander/test/tests.js and 2 other locations - About 2 hrs to fix
    core/static/vendor/jquery-expander/test/tests.js on lines 37..42
    core/static/vendor/jquery-expander/test/tests.js on lines 53..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      dds.each(function(index) {
        var txtLength = $.trim($(this).text()).length;
        var slicePoint = index === dds.length - 1 ? 92 : 97;
    
        equal(txtLength, slicePoint, msg(index, txtLength));
    Severity: Major
    Found in core/static/vendor/jquery-expander/test/tests.js and 2 other locations - About 2 hrs to fix
    core/static/vendor/jquery-expander/test/tests.js on lines 37..42
    core/static/vendor/jquery-expander/test/tests.js on lines 69..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 86.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status