bronycub/sugarcub

View on GitHub
core/static/vendor/jquery/src/ajax.js

Summary

Maintainability
F
1 mo
Test Coverage

Function ajax has 251 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    ajax: function( url, options ) {

        // If url is an object, simulate pre-1.5 signature
        if ( typeof url === "object" ) {
            options = url;
Severity: Major
Found in core/static/vendor/jquery/src/ajax.js - About 1 day to fix

    File ajax.js has 505 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    define( [
        "./core",
        "./var/document",
        "./var/rnothtmlwhite",
        "./ajax/var/location",
    Severity: Major
    Found in core/static/vendor/jquery/src/ajax.js - About 1 day to fix

      Function done has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function done( status, nativeStatusText, responses, headers ) {
                  var isSuccess, success, error, response, modified,
                      statusText = nativeStatusText;
      
                  // Ignore repeat invocations
      Severity: Major
      Found in core/static/vendor/jquery/src/ajax.js - About 2 hrs to fix

        Function ajaxConvert has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function ajaxConvert( s, response, jqXHR, isSuccess ) {
            var conv2, current, conv, tmp, prev,
                converters = {},
        
                // Work with a copy of dataTypes in case we need to modify it for conversion
        Severity: Major
        Found in core/static/vendor/jquery/src/ajax.js - About 2 hrs to fix

          Function ajaxHandleResponses has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function ajaxHandleResponses( s, jqXHR, responses ) {
          
              var ct, type, finalDataType, firstDataType,
                  contents = s.contents,
                  dataTypes = s.dataTypes;
          Severity: Minor
          Found in core/static/vendor/jquery/src/ajax.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                for ( conv2 in converters ) {
            
                                    // If conv2 outputs current
                                    tmp = conv2.split( " " );
                                    if ( tmp[ 1 ] === current ) {
            Severity: Major
            Found in core/static/vendor/jquery/src/ajax.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if ( conv && s.throws ) {
                                      response = conv( response );
                                  } else {
                                      try {
                                          response = conv( response );
              Severity: Major
              Found in core/static/vendor/jquery/src/ajax.js - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                jQuery.extend( {
                
                    // Counter for holding the number of active queries
                    active: 0,
                
                
                Severity: Major
                Found in core/static/vendor/jquery/src/ajax.js and 1 other location - About 2 wks to fix
                core/static/vendor/jquery/dist/jquery.js on lines 8740..9279

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 3109.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                function ajaxConvert( s, response, jqXHR, isSuccess ) {
                    var conv2, current, conv, tmp, prev,
                        converters = {},
                
                        // Work with a copy of dataTypes in case we need to modify it for conversion
                Severity: Major
                Found in core/static/vendor/jquery/src/ajax.js and 1 other location - About 3 days to fix
                core/static/vendor/jquery/dist/jquery.js on lines 8644..8738

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 605.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                function ajaxHandleResponses( s, jqXHR, responses ) {
                
                    var ct, type, finalDataType, firstDataType,
                        contents = s.contents,
                        dataTypes = s.dataTypes;
                Severity: Major
                Found in core/static/vendor/jquery/src/ajax.js and 2 other locations - About 1 day to fix
                core/static/vendor/jquery-expander/test/jquery.1.11.3.js on lines 8713..8763
                core/static/vendor/jquery/dist/jquery.js on lines 8586..8639

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 338.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                function addToPrefiltersOrTransports( structure ) {
                
                    // dataTypeExpression is optional and defaults to "*"
                    return function( dataTypeExpression, func ) {
                
                
                Severity: Major
                Found in core/static/vendor/jquery/src/ajax.js and 1 other location - About 1 day to fix
                core/static/vendor/jquery/dist/jquery.js on lines 8503..8534

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 219.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                function inspectPrefiltersOrTransports( structure, options, originalOptions, jqXHR ) {
                
                    var inspected = {},
                        seekingTransport = ( structure === transports );
                
                
                Severity: Major
                Found in core/static/vendor/jquery/src/ajax.js and 2 other locations - About 1 day to fix
                core/static/vendor/jquery-expander/test/jquery.1.11.3.js on lines 8666..8688
                core/static/vendor/jquery/dist/jquery.js on lines 8537..8561

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 208.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                jQuery.each( [ "get", "post" ], function( i, method ) {
                    jQuery[ method ] = function( url, data, callback, type ) {
                
                        // Shift arguments if data argument was omitted
                        if ( jQuery.isFunction( data ) ) {
                Severity: Major
                Found in core/static/vendor/jquery/src/ajax.js and 1 other location - About 5 hrs to fix
                core/static/vendor/jquery/dist/jquery.js on lines 9281..9300

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 146.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                function ajaxExtend( target, src ) {
                    var key, deep,
                        flatOptions = jQuery.ajaxSettings.flatOptions || {};
                
                    for ( key in src ) {
                Severity: Major
                Found in core/static/vendor/jquery/src/ajax.js and 2 other locations - About 4 hrs to fix
                core/static/vendor/jquery-expander/test/jquery.1.11.3.js on lines 8693..8707
                core/static/vendor/jquery/dist/jquery.js on lines 8566..8580

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 123.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                var
                    r20 = /%20/g,
                    rhash = /#.*$/,
                    rantiCache = /([?&])_=[^&]*/,
                    rheaders = /^(.*?):[ \t]*([^\r\n]*)$/mg,
                Severity: Major
                Found in core/static/vendor/jquery/src/ajax.js and 1 other location - About 2 hrs to fix
                core/static/vendor/jquery/dist/jquery.js on lines 8466..8499

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 85.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status