bronycub/sugarcub

View on GitHub
core/static/vendor/jquery/src/attributes/attr.js

Summary

Maintainability
F
4 days
Test Coverage

Function attr has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    attr: function( elem, name, value ) {
        var ret, hooks,
            nType = elem.nodeType;

        // Don't get/set attributes on text, comment and attribute nodes
Severity: Minor
Found in core/static/vendor/jquery/src/attributes/attr.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

            return ret == null ? undefined : ret;
    Severity: Major
    Found in core/static/vendor/jquery/src/attributes/attr.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return ret;
      Severity: Major
      Found in core/static/vendor/jquery/src/attributes/attr.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return value;
        Severity: Major
        Found in core/static/vendor/jquery/src/attributes/attr.js - About 30 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          jQuery.extend( {
              attr: function( elem, name, value ) {
                  var ret, hooks,
                      nType = elem.nodeType;
          
          
          Severity: Major
          Found in core/static/vendor/jquery/src/attributes/attr.js and 2 other locations - About 3 days to fix
          core/static/vendor/jquery/dist/jquery.js on lines 7468..7545
          core/static/vendor/jquery/dist/jquery.slim.js on lines 6682..6759

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 554.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

          jQuery.each( jQuery.expr.match.bool.source.match( /\w+/g ), function( i, name ) {
              var getter = attrHandle[ name ] || jQuery.find.attr;
          
              attrHandle[ name ] = function( elem, name, isXML ) {
                  var ret, handle,
          Severity: Major
          Found in core/static/vendor/jquery/src/attributes/attr.js and 2 other locations - About 7 hrs to fix
          core/static/vendor/jquery/dist/jquery.js on lines 7561..7580
          core/static/vendor/jquery/dist/jquery.slim.js on lines 6775..6794

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 175.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

          jQuery.fn.extend( {
              attr: function( name, value ) {
                  return access( this, jQuery.attr, name, value, arguments.length > 1 );
              },
          
          
          Severity: Major
          Found in core/static/vendor/jquery/src/attributes/attr.js and 3 other locations - About 2 hrs to fix
          core/static/vendor/jquery-expander/test/jquery.1.11.3.js on lines 7931..7941
          core/static/vendor/jquery/dist/jquery.js on lines 7456..7466
          core/static/vendor/jquery/dist/jquery.slim.js on lines 6670..6680

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

          boolHook = {
              set: function( elem, value, name ) {
                  if ( value === false ) {
          
                      // Remove boolean attributes when set to false
          Severity: Major
          Found in core/static/vendor/jquery/src/attributes/attr.js and 2 other locations - About 1 hr to fix
          core/static/vendor/jquery/dist/jquery.js on lines 7548..7559
          core/static/vendor/jquery/dist/jquery.slim.js on lines 6762..6773

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status