bronycub/sugarcub

View on GitHub
core/static/vendor/jquery/src/data.js

Summary

Maintainability
F
5 days
Test Coverage

Function data has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    data: function( key, value ) {
        var i, name, data,
            elem = this[ 0 ],
            attrs = elem && elem.attributes;

Severity: Minor
Found in core/static/vendor/jquery/src/data.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if ( attrs[ i ] ) {
                                name = attrs[ i ].name;
                                if ( name.indexOf( "data-" ) === 0 ) {
                                    name = jQuery.camelCase( name.slice( 5 ) );
                                    dataAttr( elem, name, data[ name ] );
    Severity: Major
    Found in core/static/vendor/jquery/src/data.js - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

              return JSON.parse( data );
      Severity: Major
      Found in core/static/vendor/jquery/src/data.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return data;
        Severity: Major
        Found in core/static/vendor/jquery/src/data.js - About 30 mins to fix

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

          jQuery.fn.extend( {
              data: function( key, value ) {
                  var i, name, data,
                      elem = this[ 0 ],
                      attrs = elem && elem.attributes;
          Severity: Major
          Found in core/static/vendor/jquery/src/data.js and 2 other locations - About 2 days to fix
          core/static/vendor/jquery/dist/jquery.js on lines 4265..4346
          core/static/vendor/jquery/dist/jquery.slim.js on lines 4265..4346

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 500.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

          function dataAttr( elem, key, data ) {
              var name;
          
              // If nothing was found internally, try to fetch any
              // data from the HTML5 data-* attribute
          Severity: Major
          Found in core/static/vendor/jquery/src/data.js and 2 other locations - About 6 hrs to fix
          core/static/vendor/jquery/dist/jquery.js on lines 4218..4239
          core/static/vendor/jquery/dist/jquery.slim.js on lines 4218..4239

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 156.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

          jQuery.extend( {
              hasData: function( elem ) {
                  return dataUser.hasData( elem ) || dataPriv.hasData( elem );
              },
          
          
          Severity: Major
          Found in core/static/vendor/jquery/src/data.js and 2 other locations - About 5 hrs to fix
          core/static/vendor/jquery/dist/jquery.js on lines 4241..4263
          core/static/vendor/jquery/dist/jquery.slim.js on lines 4241..4263

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 149.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

          function getData( data ) {
              if ( data === "true" ) {
                  return true;
              }
          
          
          Severity: Major
          Found in core/static/vendor/jquery/src/data.js and 2 other locations - About 3 hrs to fix
          core/static/vendor/jquery/dist/jquery.js on lines 4193..4216
          core/static/vendor/jquery/dist/jquery.slim.js on lines 4193..4216

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status