Sign upLogin

brooklynDev/airborne

View on GitHub
Star

Showing 8 of 8 total issues

Method make_request has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    def make_request(method, url, options = {})
      headers = base_headers.merge(options[:headers] || {})
      verify_ssl = options.fetch(:verify_ssl, true)
      res = if method == :post || method == :patch || method == :put || method == :delete
        begin
Severity: Minor
Found in lib/airborne/rest_client_requester.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method expect_json_types_impl has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def expect_json_types_impl(expected, actual)
      return if nil_optional_hash?(expected, actual)

      @mapper ||= get_mapper
Severity: Minor
Found in lib/airborne/request_expectations.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method expect_json_impl has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def expect_json_impl(expected, actual)
      return if nil_optional_hash?(expected, actual)

      actual = actual.to_s if expected.is_a?(Regexp)
Severity: Minor
Found in lib/airborne/request_expectations.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_by_path has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def get_by_path(path, json, &block)
      fail PathError, "Invalid Path, contains '..'" if /\.\./ =~ path
      type = false
      parts = path.split('.')
      parts.each_with_index do |part, index|
Severity: Minor
Found in lib/airborne/path_matcher.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method make_request has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def make_request(method, url, options = {})
      headers = base_headers.merge(options[:headers] || {})
      verify_ssl = options.fetch(:verify_ssl, true)
      res = if method == :post || method == :patch || method == :put || method == :delete
        begin
Severity: Minor
Found in lib/airborne/rest_client_requester.rb - About 1 hr to fix

    Method walk_with_path has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def walk_with_path(type, index, path, parts, json, &block)
    Severity: Minor
    Found in lib/airborne/path_matcher.rb - About 45 mins to fix

      Method walk_with_path has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def walk_with_path(type, index, path, parts, json, &block)
      last_error  = nil
      item_count = json.length
      error_count = 0
      json.each do |element|
      Severity: Minor
      Found in lib/airborne/path_matcher.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method convert_expectations_for_json_sizes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def convert_expectations_for_json_sizes(old_expectations)
      unless old_expectations.is_a?(Hash)
        return convert_expectation_for_json_sizes(old_expectations)
      end
      Severity: Minor
      Found in lib/airborne/request_expectations.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language