Sign upLogin

bruslim/peerface

View on GitHub
Star

Showing 6 of 39 total issues

Function Handshake has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Handshake = module.exports = function Handshake(bytes) {
  TcpMessage.call(this, bytes);
  Object.defineProperties(this, {
    _pstrlen: {
      get: function() {
Severity: Major
Found in lib/dto/Handshake.js - About 2 hrs to fix

    Function exports has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var KeepAlive = module.exports = function(bytes) {
  TcpMessage.call(this, bytes);
  if (!!bytes) {
    Object.defineProperties(this, {
      len: {
    Severity: Minor
    Found in lib/dto/KeepAlive.js - About 1 hr to fix

      Function exports has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var BaseRequestMessage = module.exports = function(bytes) {
  PeerMessage.call(this, bytes);
  Object.defineProperties(this, {
    _index: {
      value: new Buffer(4)
      Severity: Minor
      Found in lib/dto/BaseRequestMessage.js - About 1 hr to fix

        Function exports has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        var PieceMessage = module.exports = function(bytes) {
  PeerMessage.call(this, bytes);
  Object.defineProperties(this, {
    _index: {
      value: new Buffer(4)
        Severity: Minor
        Found in lib/dto/PieceMessage.js - About 1 hr to fix

          Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var PeerConnection = module.exports = function(socket){
  events.EventEmitter.call(this);
  this.setMaxListeners(0);
  Object.defineProperties(this,{
    infoHash: {
          Severity: Minor
          Found in lib/PeerConnection.js - About 1 hr to fix

            Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            var BitfieldMessage = module.exports = function(bytes) {
  PeerMessage.call(this, bytes);
  Object.defineProperties(this,{
    _bitfield: {
      get: function() {
            Severity: Minor
            Found in lib/dto/BitfieldMessage.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language