Showing 30 of 38 total issues
Method ignore_comp
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
def ignore_comp(should_hsh, is_hsh)
match = true
should_hsh.each do |k, v|
if v.is_a?(Hash) && is_hsh[k].is_a?(Hash)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method remove_comp
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
def remove_comp(should_hsh, is_hsh)
should_keys = should_hsh.keys - resource[:ignored_properties] - resource[:protected_properties]
is_keys = is_hsh.keys - resource[:ignored_properties] - resource[:protected_properties]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method monitor_site
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
def monitor_site(desired_state = :on)
# If context root is not blank, need to ensure URI has a trailing slash,
# otherwise the system redirects, thus shutting down before installation is complete.
uri_s = "http://localhost:#{@property_hash[:port]}/"
uri_s = "#{uri_s}#{@property_hash[:context_root]}/" if @property_hash[:context_root]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method flush
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def flush
return unless @property_flush[:ensure]
Puppet.debug('aem_crx_package::ruby - Flushing out to AEM.')
self.class.require_libs
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method submit
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def submit
uri = URI(content_uri)
begin
retries ||= @resource[:retries]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method current_config
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def current_config
pid = resource[:pid] || resource[:name]
uri = URI("#{config_mgr_uri}/#{pid}.json")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method current_content
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def current_content
depth = get_depth(resource[:properties])
uri = URI("#{content_uri}.#{depth}.json")
http = Net::HTTP.new(uri.host, uri.port)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_aem
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def check_aem
uri = URI("#{aem_root}/system/console/bundles.json")
http = Net::HTTP.new(uri.host, uri.port)
http.set_debug_output($stdout) if Puppet[:debug]
req = Net::HTTP::Get.new(uri.request_uri)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method insync?
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def insync?(is_val)
if resource[:handle_missing] == :merge
should.each do |k, v|
# Desired state has a configuration value that doesn't exist
return false unless is_val.key?(k)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find_package
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def find_package
client = build_client
path = "/etc/packages/#{@resource[:group]}/#{@resource[:pkg]}-.zip"
begin
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_aem
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def check_aem
uri = URI("#{aem_root}/system/console/bundles.json")
http = Net::HTTP.new(uri.host, uri.port)
http.set_debug_output($stdout) if Puppet[:debug]
req = Net::HTTP::Get.new(uri.request_uri)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_aem
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def check_aem
uri = URI("#{aem_root}/system/console/bundles.json")
http = Net::HTTP.new(uri.host, uri.port)
http.set_debug_output($stdout) if Puppet[:debug]
req = Net::HTTP::Get.new(uri.request_uri)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method json_to_configuration
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def json_to_configuration(json)
cfg = {}
json[0]['properties'].each do |k, v|
if v['is_set']
cfg[k] = v['value'] unless v['value'].nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_delete
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def build_delete(is_val, should)
to_delete = {}
is_val.each do |key, value|
next if ignored?(key, is_val)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method aem_root
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def aem_root
return @aem_root if @aem_root
port = nil
context_root = nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method aem_root
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def aem_root
return @aem_root if @aem_root
port = nil
context_root = nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method aem_root
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def aem_root
return @aem_root if @aem_root
port = nil
context_root = nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method raise_on_failure
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def raise_on_failure(api_response)
if api_response.is_a?(CrxPackageManager::ServiceExecResponse)
raise(api_response.msg) unless api_response.success
else
hash = XmlSimple.xml_in(api_response, ForceArray: false, KeyToSymbol: true, AttrToSymbol: true)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_parameters
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def build_parameters(initial)
params = {}
if @property_flush[:ensure] != :absent
if @property_flush[:existing_config] && resource[:handle_missing] == :merge
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method get_depth
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def get_depth(data)
max_depth = 1
return max_depth unless data
depth_func = lambda do |hsh, cur_depth|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"