Sign upLogin

budde377/Part

View on GitHub
Star

Showing 127 of 140 total issues

File GenericObjectTypeHandlerImpl.php has 426 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace ChristianBudde\Part\controller\ajax\type_handler;

use ChristianBudde\Part\controller\ajax\Server;
use ChristianBudde\Part\controller\json\JSONFunction;
Severity: Minor
Found in lib/controller/ajax/type_handler/GenericObjectTypeHandlerImpl.php - About 6 hrs to fix

UserImpl has 37 functions (exceeds 20 allowed). Consider refactoring.
Open

class UserImpl implements User
{
    use RequestTrait;
    use ValidationTrait;
Severity: Minor
Found in lib/model/user/UserImpl.php - About 4 hrs to fix

File UserImpl.php has 343 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace ChristianBudde\Part\model\user;
use ChristianBudde\Part\BackendSingletonContainer;
use ChristianBudde\Part\controller\ajax\type_handler\TypeHandler;
use ChristianBudde\Part\controller\json\UserObjectImpl;
Severity: Minor
Found in lib/model/user/UserImpl.php - About 4 hrs to fix

GenericObjectTypeHandlerImpl has 33 functions (exceeds 20 allowed). Consider refactoring.
Open

class GenericObjectTypeHandlerImpl implements TypeHandler
{


    private $object;
Severity: Minor
Found in lib/controller/ajax/type_handler/GenericObjectTypeHandlerImpl.php - About 4 hrs to fix

File PageOrderImpl.php has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace ChristianBudde\Part\model\page;

use ChristianBudde\Part\BackendSingletonContainer;
use ChristianBudde\Part\controller\ajax\type_handler\TypeHandler;
Severity: Minor
Found in lib/model/page/PageOrderImpl.php - About 3 hrs to fix

Function parametersCheck has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    private function parametersCheck(array $functionArgs, array $parameters)
    {


        $numReqParam = 0;
Severity: Minor
Found in lib/controller/ajax/type_handler/GenericObjectTypeHandlerImpl.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ParserImpl.php has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace ChristianBudde\Part\controller\function_string;

use ChristianBudde\Part\controller\function_string\ast\AArray;
use ChristianBudde\Part\controller\function_string\ast\Argument;
Severity: Minor
Found in lib/controller/function_string/ParserImpl.php - About 3 hrs to fix

File ConfigImpl.php has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace ChristianBudde\Part;

use ChristianBudde\Part\exception\InvalidXMLException;
use DOMDocument;
Severity: Minor
Found in lib/ConfigImpl.php - About 3 hrs to fix

NotFoundPageImpl has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class NotFoundPageImpl implements Page
{

    private $container;
Severity: Minor
Found in lib/model/page/NotFoundPageImpl.php - About 3 hrs to fix

ConfigImpl has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class ConfigImpl implements Config
{
    private $variables;
    private $owner;
    private $domain;
Severity: Minor
Found in lib/ConfigImpl.php - About 3 hrs to fix

DefaultPageImpl has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class DefaultPageImpl implements Page
{

    private $template,$title,$alias,$id;
    private $container;
Severity: Minor
Found in lib/model/page/DefaultPageImpl.php - About 3 hrs to fix

PageImpl has 28 functions (exceeds 20 allowed). Consider refactoring.
Open

class PageImpl implements Page
{

    private $page_id;
    private $title = '';
Severity: Minor
Found in lib/model/page/PageImpl.php - About 3 hrs to fix

PageOrderImpl has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

class PageOrderImpl implements PageOrder
{

    private $database;
    private $connection;
Severity: Minor
Found in lib/model/page/PageOrderImpl.php - About 3 hrs to fix

Function parseDecoded has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    private function parseDecoded($obj){

        if(!is_array($obj)){
            return $obj;
        }
Severity: Minor
Found in lib/controller/json/ParserImpl.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

FileLibraryImpl has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class FileLibraryImpl implements FileLibrary{
//    private $config;
    private $filesDir;
    private $whiteList = array();
    private $whitelistFile;
Severity: Minor
Found in lib/util/file/FileLibraryImpl.php - About 2 hrs to fix

ImageFileImpl has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class ImageFileImpl extends FileImpl implements ImageFile
{

    /** @var  Imagick */
    private $imagick;
Severity: Minor
Found in lib/util/file/ImageFileImpl.php - About 2 hrs to fix

Function update has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function update()
    {
        $this->setUpVersion();
        $connection = $this->getConnection();
        foreach ($this->folders as $name => $path) {
Severity: Minor
Found in lib/util/db/MySQLDBImpl.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

ParserImpl has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class ParserImpl implements Parser
{

    private $tokens;
    private $num_tokens;
Severity: Minor
Found in lib/controller/function_string/ParserImpl.php - About 2 hrs to fix

UserLibraryImpl has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class UserLibraryImpl implements UserLibrary, Observer, \Serializable
{
    private $container;
    private $userList = [];
    private $database;
Severity: Minor
Found in lib/model/user/UserLibraryImpl.php - About 2 hrs to fix

FileImpl has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class FileImpl implements File
{
    use FilePathTrait;
    protected $filePath;
    protected $mode = File::FILE_MODE_RW_POINTER_AT_END;
Severity: Minor
Found in lib/util/file/FileImpl.php - About 2 hrs to fix
Severity
Category
Status
Source
Language