bundler/bundler

View on GitHub

Showing 262 of 280 total issues

Method help has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def help(cli = nil)
      case cli
      when "gemfile" then command = "gemfile"
      when nil       then command = "bundle"
      else command = "bundle-#{cli}"
Severity: Minor
Found in lib/bundler/cli.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def initialize(index, source_requirements, base, gem_version_promoter, additional_base_requirements, platforms)
Severity: Minor
Found in lib/bundler/resolver.rb - About 45 mins to fix

    Method lock has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def lock(file, preserve_unknown_sections = false)
          contents = to_lock
    
          # Convert to \r\n if the existing lock has them
          # i.e., Windows with `git config core.autocrlf=true`
    Severity: Minor
    Found in lib/bundler/definition.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method concat_ruby_version_requirements has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def concat_ruby_version_requirements(ruby_version, ruby_versions = [])
          return ruby_versions unless ruby_version
          if ruby_version.patchlevel
            ruby_versions << ruby_version.to_gem_version_with_patchlevel
          else
    Severity: Minor
    Found in lib/bundler/definition.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method version_message has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def version_message(spec)
          message = "#{spec.name} #{spec.version}"
          message += " (#{spec.platform})" if spec.platform != Gem::Platform::RUBY && !spec.platform.nil?
    
          if Bundler.locked_gems
    Severity: Minor
    Found in lib/bundler/source.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_requirements has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def parse_requirements(raw_requirements)
            requirements = []
            checksum = raw_requirements.match(/\A(checksum):([^,]+)/)
            if checksum
              requirements << [checksum[1], [checksum[2]]]
    Severity: Minor
    Found in lib/bundler/compact_index_client/gem_parser.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method register_plugin has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def register_plugin(name, path, load_paths, commands, sources, hooks)
            old_commands = @commands.dup
    
            common = commands & @commands.keys
            raise CommandConflict.new(name, common) unless common.empty?
    Severity: Minor
    Found in lib/bundler/plugin/index.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method log_error has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def log_error(error)
          case error
          when YamlSyntaxError
            Bundler.ui.error error.message
            Bundler.ui.trace error.orig_exception
    Severity: Minor
    Found in lib/bundler/friendly_errors.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                  if dep.requirements_list.include?(">= 0") && !current.requirements_list.include?(">= 0")
                    update_prompt = ". Gem already added"
                  else
                    update_prompt = ". If you want to update the gem version, run `bundle update #{current.name}`"
    
    
    Severity: Major
    Found in lib/bundler/dsl.rb - About 45 mins to fix

      Method register_plugin has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def register_plugin(name, path, load_paths, commands, sources, hooks)
      Severity: Minor
      Found in lib/bundler/plugin/index.rb - About 45 mins to fix

        Method run_hooks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                def run_hooks(type)
                  hooks_meth = "#{type}_hooks"
                  return unless Gem.respond_to?(hooks_meth)
                  Gem.send(hooks_meth).each do |hook|
                    result = hook.call(self)
        Severity: Minor
        Found in lib/bundler/source/path/installer.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method load_index has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def load_index(index_file, global = false)
                SharedHelpers.filesystem_access(index_file, :read) do |index_f|
                  valid_file = index_f && index_f.exist? && !index_f.size.zero?
                  break unless valid_file
        
        
        Severity: Minor
        Found in lib/bundler/plugin/index.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method post_install has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                def post_install
                  SharedHelpers.chdir(@gem_dir) do
                    run_hooks(:pre_install)
        
                    unless @disable_extensions
        Severity: Minor
        Found in lib/bundler/source/path/installer.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method cover? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def cover?(v)
                return false if left.inclusive && left.version > v
                return false if !left.inclusive && left.version >= v
        
                if right.version != INFINITY
        Severity: Minor
        Found in lib/bundler/version_ranges.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def run
                @groups.each do |group|
                  g.add_nodes(
                    group, {
                      :style     => "filled",
        Severity: Minor
        Found in lib/bundler/graph.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def initialize(env, output_file, show_version = false, show_requirements = false, output_format = "png", without = [])
        Severity: Minor
        Found in lib/bundler/graph.rb - About 45 mins to fix

          Method checkout has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def checkout
                    return if path.exist? && has_revision_cached?
                    extra_ref = "#{Shellwords.shellescape(ref)}:#{Shellwords.shellescape(ref)}" if ref && ref.start_with?("refs/")
          
                    Bundler.ui.info "Fetching #{URICredentialsFilter.credential_filtered_uri(uri)}"
          Severity: Minor
          Found in lib/bundler/source/git/git_proxy.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def initialize(versions, patchlevel, engine, engine_version)
                # The parameters to this method must satisfy the
                # following constraints, which are verified in
                # the DSL:
                #
          Severity: Minor
          Found in lib/bundler/ruby_version.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def run
                Bundler.settings.set_command_option_if_given :path, options[:path]
          
                begin
                  definition = Bundler.definition
          Severity: Minor
          Found in lib/bundler/cli/check.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def run
                if File.exist?(gemfile)
                  Bundler.ui.error "#{gemfile} already exists at #{File.expand_path(gemfile)}"
                  exit 1
                end
          Severity: Minor
          Found in lib/bundler/cli/init.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language