Showing 26 of 28 total issues
Method SlaveNode.forceKillPid
has 6 return statements (exceeds 4 allowed). Open
Open
func (s *SlaveNode) forceKillPid(pid int) error {
if pid <= 0 {
return nil
}
Function sendClientPidAndArgumentsToCommand
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
func sendClientPidAndArgumentsToCommand(commandUsock *unixsocket.Usock, clientPid int, argCount int, argFD int, err error) error {
Function buildFileMonitor
has 5 return statements (exceeds 4 allowed). Open
Open
func buildFileMonitor(fileChangeDelay time.Duration) (filemonitor.FileMonitor, error) {
if portStr := os.Getenv(listenerPortVar); portStr != "" {
port, err := strconv.Atoi(portStr)
if err != nil {
return nil, fmt.Errorf("%s must be an integer or empty string: %v", listenerPortVar, err)
Function extractFileDescriptorFromOOB
has 5 return statements (exceeds 4 allowed). Open
Open
func extractFileDescriptorFromOOB(oob []byte) (int, error) {
scms, err := syscall.ParseSocketControlMessage(oob)
if err != nil {
return -1, err
}
Method suites
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def suites
# Since we're not using `ruby -Itest -Ilib` to run the tests, we need to add this directory to the `LOAD_PATH`
$:.unshift "./test", "./lib"
if framework == :testunit1
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method fileListener.handleConnection
has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring. Open
Open
func (f *fileListener) handleConnection(conn net.Conn, ch chan string) {
// Handle writes
stop := make(chan struct{})
go func() {
for {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"