burningpony/phd_checker

File jquery-ui-timepicker-addon.js has 570 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
* jQuery timepicker addon
* By: Trent Richardson [http://trentrichardson.com]
* Version 0.9
* Last Modified: 11/29/2010

Function _injectTimePicker has 184 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _injectTimePicker: function() {
        var $dp = this.inst.dpDiv,
            o = this._defaults,
            tp_inst = this,
            // Added by Peter Medeiros:

Function _newInst has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _newInst: function($input, o) {
        var tp_inst = new Timepicker(),
            inlineSettings = {};

        for (var attrName in this._defaults) {

Function Timepicker has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function Timepicker() {
    this.regional = []; // Available regional settings, indexed by language code
    this.regional[''] = { // Default regional settings
        currentText: 'Now',
        closeText: 'Done',

Function _formatTime has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _formatTime: function(time, format, ampm) {
        if (ampm == undefined) ampm = this._defaults.ampm;
        time = time || { hour: this.hour, minute: this.minute, second: this.second, ampm: this.ampm };
        var tmptime = format || this._defaults.timeFormat.toString();

Function _parseTime has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _parseTime: function(timeString, withDate) {
        var regstr = this._defaults.timeFormat.toString()
                .replace(/h{1,2}/ig, '(\\d?\\d)')
                .replace(/m{1,2}/ig, '(\\d?\\d)')
                .replace(/s{1,2}/ig, '(\\d?\\d)')

Avoid deeply nested control flow statements.

Open

                            } else if (aph == 12) h = 12;
                            else h = aph + 12;

Avoid deeply nested control flow statements.

Open

                        if (h == 0) tmph = 12 +'a';
                        else if (h < 12) tmph += 'a';
                        else tmph += 'p';

Avoid deeply nested control flow statements.

Open

                                if (aph == 12) h = 0;
                                else h = aph;

Consider simplifying this complex logical expression.

Open

        if ((hour < defaults.hourMin || hour > defaults.hourMax) || (minute < defaults.minuteMin || minute > defaults.minuteMax) || (second < defaults.secondMin || second > defaults.secondMax)) {
            hour = defaults.hourMin;
            minute = defaults.minuteMin;
            second = defaults.secondMin;
        }

Consider simplifying this complex logical expression.

Open

        if (force || this.hour != hour || this.minute != minute || this.second != second || (this.ampm.length > 0 && this.ampm != ampm))
            hasChanged = true;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (o.showMinute && o.minuteGrid > 0) {
                html += '<dd class="ui_tpicker_minute ui_tpicker_minute_' + o.minuteGrid + '">' +
                        '<div id="ui_tpicker_minute_' + dp_id + '"' +
                        ((o.showMinute) ? '' : noDisplay) + '></div>' +
                        '<div style="padding-left: 1px"><table><tr>';

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (o.showSecond && o.secondGrid > 0) {
                html += '<dd class="ui_tpicker_second ui_tpicker_second_' + o.secondGrid + '">' +
                        '<div id="ui_tpicker_second_' + dp_id + '"' +
                        ((o.showSecond) ? '' : noDisplay) + '></div>' +
                        '<div style="padding-left: 1px"><table><tr>';

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                $tp.find(".ui_tpicker_minute table").css({
                    width: size + "%",
                    marginLeft: (size / (-2 * minuteGridSize)) + "%",
                    borderCollapse: 'collapse'
                }).find("td").each(function(index) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                $tp.find(".ui_tpicker_second table").css({
                    width: size + "%",
                    marginLeft: (size / (-2 * secondGridSize)) + "%",
                    borderCollapse: 'collapse'
                }).find("td").each(function(index) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.second_slider = $tp.find('#ui_tpicker_second_'+ dp_id).slider({
                orientation: "horizontal",
                value: this.second,
                min: o.secondMin,
                max: secMax,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            this.hour_slider = $tp.find('#ui_tpicker_hour_'+ dp_id).slider({
                orientation: "horizontal",
                value: this.hour,
                min: o.hourMin,
                max: hourMax,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            html += '<dt class="ui_tpicker_minute_label" id="ui_tpicker_minute_label_' + dp_id + '"' +
                    ((o.showMinute) ? '' : noDisplay) + '>' + o.minuteText + '</dt>';

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            html += '<dt class="ui_tpicker_second_label" id="ui_tpicker_second_label_' + dp_id + '"' +
                    ((o.showSecond) ? '' : noDisplay) + '>' + o.secondText + '</dt>';

• Read up
  Read up