burtlo/metro

View on GitHub

Showing 8 of 10 total issues

Class Scene has 36 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Scene
    include Units

    #
    # As Scene does a lot of work for you with regarding to setting up content, it is
Severity: Minor
Found in lib/metro/scene.rb - About 4 hrs to fix

    Class Label has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Label < Model
    
          # @attribute
          # The position of the label
          property :position
    Severity: Minor
    Found in lib/metro/models/ui/label.rb - About 2 hrs to fix

      Method changes_for_version has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.changes_for_version(version)
      
          change = Struct::Changes.new(nil,[])
      
          grab_changes = false
      Severity: Minor
      Found in lib/metro/version.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method reload_game_because_files_changed has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def reload_game_because_files_changed(changed)
              log.debug "Metro has detected #{changed.count} game source #{changed.count != 1 ? 'files have' : 'file has'} changed. RELOADING GAME CODE!"
              if Metro.game_has_valid_code?
                Game.current_scene.after(1.tick) do
                  Metro.reload!
      Severity: Minor
      Found in lib/setup_handlers/reload_game_on_game_file_changes.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def update
              scene.drawers.each do |drawer|
                next if (drawer.bounds == Bounds.none and should_hide_boundless_actors)
                label = labels[drawer.name]
      
      
      Severity: Minor
      Found in lib/metro/models/ui/model_labeler.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method property has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def property(name,options={},&block)
      
              # Use the name as the property type if one has not been provided.
      
              property_type = options[:type] || name
      Severity: Minor
      Found in lib/metro/models/properties/property_owner.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def initialize(*args)
          if args.length == 1
            value = args.first
            if value.is_a? Gosu::Color
              gosu_initialize value.alpha, value.red, value.green, value.blue
      Severity: Minor
      Found in lib/gosu_ext/color.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method show has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def show
              adjust_alpha_on_colors(alpha)
      
              previous_width = 0
      
      
      Severity: Minor
      Found in lib/metro/models/ui/menu.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language