camdub/Internships

View on GitHub

Showing 387 of 584 total issues

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @industry = Industry.find(params[:id])

    respond_to do |format|
      if @industry.update_attributes(params[:industry])
Severity: Major
Found in app/controllers/industries_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @student = Student.find(params[:id])

    respond_to do |format|
      if @student.update_attributes(params[:student])
Severity: Major
Found in app/controllers/students_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @state = State.find(params[:id])

    respond_to do |format|
      if @state.update_attributes(params[:state])
Severity: Major
Found in app/controllers/states_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @location = Location.find(params[:id])

    respond_to do |format|
      if @location.update_attributes(params[:location])
Severity: Major
Found in app/controllers/locations_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @academic_contact = AcademicContact.find(params[:id])

    respond_to do |format|
      if @academic_contact.update_attributes(params[:academic_contact])
Severity: Major
Found in app/controllers/academic_contacts_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @role = Role.find(params[:id])

    respond_to do |format|
      if @role.update_attributes(params[:role])
Severity: Major
Found in app/controllers/roles_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @country = Country.find(params[:id])

    respond_to do |format|
      if @country.update_attributes(params[:country])
Severity: Major
Found in app/controllers/countries_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @academic_focus_type = AcademicFocusType.find(params[:id])

    respond_to do |format|
      if @academic_focus_type.update_attributes(params[:academic_focus_type])
Severity: Major
Found in app/controllers/academic_focus_types_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @long_term_goal = LongTermGoal.find(params[:id])

    respond_to do |format|
      if @long_term_goal.update_attributes(params[:long_term_goal])
Severity: Major
Found in app/controllers/long_term_goals_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    horiz: function(x, relative) {
        this._path += (relative ? 'h' : 'H') + (isArray(x) ? x.join(' ') : x);
        return this;
    },
Severity: Major
Found in public/javascripts/jquery.svg/jquery.svg.js and 1 other location - About 1 hr to fix
public/javascripts/jquery.svg/jquery.svg.js on lines 1119..1122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @field = Field.find(params[:id])

    respond_to do |format|
      if @field.update_attributes(params[:field])
Severity: Major
Found in app/controllers/fields_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @task = Task.find(params[:id])

    respond_to do |format|
      if @task.update_attributes(params[:task])
Severity: Major
Found in app/controllers/tasks_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @provider_type = ProviderType.find(params[:id])

    respond_to do |format|
      if @provider_type.update_attributes(params[:provider_type])
Severity: Major
Found in app/controllers/provider_types_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @college = College.find(params[:id])

    respond_to do |format|
      if @college.update_attributes(params[:college])
Severity: Major
Found in app/controllers/colleges_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @financial_assistance_option = FinancialAssistanceOption.find(params[:id])

    respond_to do |format|
      if @financial_assistance_option.update_attributes(params[:financial_assistance_option])
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @department = Department.find(params[:id])

    respond_to do |format|
      if @department.update_attributes(params[:department])
Severity: Major
Found in app/controllers/departments_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this._wrapper.rect(bg, dims[this.X], dims[this.Y], dims[this.W], dims[this.H], this._areaFormat);
Severity: Major
Found in public/javascripts/jquery.svg/jquery.svgplot.js and 1 other location - About 1 hr to fix
public/javascripts/jquery.svg/jquery.svggraph.js on lines 379..379

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    
    @user = User.find(params[:id])

    respond_to do |format|
Severity: Major
Found in app/controllers/users_controller.rb and 24 other locations - About 1 hr to fix
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_option_types_controller.rb on lines 65..74
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

  def update
    @financial_assistance_option_type = FinancialAssistanceOptionType.find(params[:id])

    respond_to do |format|
      if @financial_assistance_option_type.update_attributes(params[:financial_assistance_option_type])
app/controllers/academic_contacts_controller.rb on lines 69..78
app/controllers/academic_focus_types_controller.rb on lines 65..74
app/controllers/academic_focuses_controller.rb on lines 70..79
app/controllers/colleges_controller.rb on lines 65..74
app/controllers/countries_controller.rb on lines 65..74
app/controllers/departments_controller.rb on lines 65..74
app/controllers/fields_controller.rb on lines 70..79
app/controllers/financial_assistance_options_controller.rb on lines 67..76
app/controllers/industries_controller.rb on lines 65..74
app/controllers/internship_instances_controller.rb on lines 65..74
app/controllers/internships_controller.rb on lines 191..199
app/controllers/languages_controller.rb on lines 67..76
app/controllers/locations_controller.rb on lines 67..76
app/controllers/long_term_goals_controller.rb on lines 67..76
app/controllers/provider_contacts_controller.rb on lines 75..84
app/controllers/provider_types_controller.rb on lines 65..74
app/controllers/providers_controller.rb on lines 68..77
app/controllers/roles_controller.rb on lines 58..67
app/controllers/semesters_controller.rb on lines 67..76
app/controllers/states_controller.rb on lines 65..74
app/controllers/students_controller.rb on lines 58..67
app/controllers/tags_controller.rb on lines 67..76
app/controllers/tasks_controller.rb on lines 67..76
app/controllers/users_controller.rb on lines 79..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    vert: function(y, relative) {
        this._path += (relative ? 'v' : 'V') + (isArray(y) ? y.join(' ') : y);
        return this;
    },
Severity: Major
Found in public/javascripts/jquery.svg/jquery.svg.js and 1 other location - About 1 hr to fix
public/javascripts/jquery.svg/jquery.svg.js on lines 1108..1111

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language