camdub/Internships

View on GitHub
public/javascripts/tinyeditor/themes/advanced/js/image.js

Summary

Maintainability
F
3 days
Test Coverage

Function getAttrib has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    getAttrib : function(e, at) {
        var ed = tinyMCEPopup.editor, dom = ed.dom, v, v2;

        if (ed.settings.inline_styles) {
            switch (at) {
Severity: Minor
Found in public/javascripts/tinyeditor/themes/advanced/js/image.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateStyle has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    updateStyle : function() {
        var dom = tinyMCEPopup.dom, st, v, f = document.forms[0];

        if (tinyMCEPopup.editor.settings.inline_styles) {
            st = tinyMCEPopup.dom.parseStyle(this.styleVal);
Severity: Minor
Found in public/javascripts/tinyeditor/themes/advanced/js/image.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateStyle has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    updateStyle : function() {
        var dom = tinyMCEPopup.dom, st, v, f = document.forms[0];

        if (tinyMCEPopup.editor.settings.inline_styles) {
            st = tinyMCEPopup.dom.parseStyle(this.styleVal);
Severity: Minor
Found in public/javascripts/tinyeditor/themes/advanced/js/image.js - About 1 hr to fix

    Function getAttrib has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        getAttrib : function(e, at) {
            var ed = tinyMCEPopup.editor, dom = ed.dom, v, v2;
    
            if (ed.settings.inline_styles) {
                switch (at) {
    Severity: Minor
    Found in public/javascripts/tinyeditor/themes/advanced/js/image.js - About 1 hr to fix

      Function update has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          update : function() {
              var f = document.forms[0], nl = f.elements, ed = tinyMCEPopup.editor, args = {}, el;
      
              tinyMCEPopup.restoreSelection();
      
      Severity: Minor
      Found in public/javascripts/tinyeditor/themes/advanced/js/image.js - About 1 hr to fix

        Function update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            update : function() {
                var f = document.forms[0], nl = f.elements, ed = tinyMCEPopup.editor, args = {}, el;
        
                tinyMCEPopup.restoreSelection();
        
        Severity: Minor
        Found in public/javascripts/tinyeditor/themes/advanced/js/image.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                return '';
        Severity: Major
        Found in public/javascripts/tinyeditor/themes/advanced/js/image.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                                  return parseInt(v.replace(/[^0-9]/g, ''));
          Severity: Major
          Found in public/javascripts/tinyeditor/themes/advanced/js/image.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return v;
            Severity: Major
            Found in public/javascripts/tinyeditor/themes/advanced/js/image.js - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  fillFileList : function(id, l) {
                      var dom = tinyMCEPopup.dom, lst = dom.get(id), v, cl;
              
                      l = window[l];
              
              Severity: Major
              Found in public/javascripts/tinyeditor/themes/advanced/js/image.js and 1 other location - About 7 hrs to fix
              public/javascripts/tinyeditor/themes/advanced/js/link.js on lines 97..110

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 175.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (v) {
                              delete st['margin'];
                              st['margin-left'] = v + 'px';
                              st['margin-right'] = v + 'px';
                          } else {
              Severity: Major
              Found in public/javascripts/tinyeditor/themes/advanced/js/image.js and 1 other location - About 1 hr to fix
              public/javascripts/tinyeditor/themes/advanced/js/image.js on lines 146..153

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (v) {
                              delete st['margin'];
                              st['margin-top'] = v + 'px';
                              st['margin-bottom'] = v + 'px';
                          } else {
              Severity: Major
              Found in public/javascripts/tinyeditor/themes/advanced/js/image.js and 1 other location - About 1 hr to fix
              public/javascripts/tinyeditor/themes/advanced/js/image.js on lines 135..142

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              case 'hspace':
                                  v = dom.getStyle(e, 'margin-left')
                                  v2 = dom.getStyle(e, 'margin-right');
                                  if (v && v == v2)
                                      return parseInt(v.replace(/[^0-9]/g, ''));
              Severity: Major
              Found in public/javascripts/tinyeditor/themes/advanced/js/image.js and 1 other location - About 1 hr to fix
              public/javascripts/tinyeditor/themes/advanced/js/image.js on lines 183..189

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              case 'vspace':
                                  v = dom.getStyle(e, 'margin-top')
                                  v2 = dom.getStyle(e, 'margin-bottom');
                                  if (v && v == v2)
                                      return parseInt(v.replace(/[^0-9]/g, ''));
              Severity: Major
              Found in public/javascripts/tinyeditor/themes/advanced/js/image.js and 1 other location - About 1 hr to fix
              public/javascripts/tinyeditor/themes/advanced/js/image.js on lines 175..181

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (url = tinyMCEPopup.getParam("external_image_list_url"))
                          document.write('<script language="javascript" type="text/javascript" src="' + tinyMCEPopup.editor.documentBaseURI.toAbsolute(url) + '"></script>');
              Severity: Minor
              Found in public/javascripts/tinyeditor/themes/advanced/js/image.js and 1 other location - About 50 mins to fix
              public/javascripts/tinyeditor/themes/advanced/js/link.js on lines 7..8

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 51.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status