Sign upLogin

camdub/Internships

View on GitHub
Star
public/javascripts/tinyeditor/tinyeditor.js

Summary

Maintainability
F
4 days
Test Coverage

Function editor has a Cognitive Complexity of 97 (exceeds 5 allowed). Consider refactoring.
Open

TINY.editor=function(){
    var c=[], offset=-30;
    c['cut']=[1,'Cut','a','cut',1];
    c['copy']=[2,'Copy','a','copy',1];
    c['paste']=[3,'Paste','a','paste',1];
Severity: Minor
Found in public/javascripts/tinyeditor/tinyeditor.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function editor has 199 lines of code (exceeds 25 allowed). Consider refactoring.
Open

TINY.editor=function(){
    var c=[], offset=-30;
    c['cut']=[1,'Cut','a','cut',1];
    c['copy']=[2,'Copy','a','copy',1];
    c['paste']=[3,'Paste','a','paste',1];
Severity: Major
Found in public/javascripts/tinyeditor/tinyeditor.js - About 7 hrs to fix

    Function edit has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function edit(n,obj){
        this.n=n; window[n]=this; this.t=T$(obj.id); this.obj=obj; this.xhtml=obj.xhtml;
        var p=document.createElement('div'), w=document.createElement('div'), h=document.createElement('div'),
        l=obj.controls.length, i=0;
        this.i=document.createElement('iframe'); this.i.frameBorder=0;
    Severity: Major
    Found in public/javascripts/tinyeditor/tinyeditor.js - About 3 hrs to fix

      Function toggle has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          edit.prototype.toggle=function(post,div){
        if(!this.d){
            var v=this.t.value;
            if(div){div.innerHTML=this.obj.toggletext||'source'}
            if(this.xhtml&&!this.ie){
      Severity: Minor
      Found in public/javascripts/tinyeditor/tinyeditor.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                        for(x;x<sl;x++){
                    var style=styles[x];
                    sel.options[x]=new Option(style[0],style[1])
                }
        Severity: Major
        Found in public/javascripts/tinyeditor/tinyeditor.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      }else if(c[id]){
                var div=document.createElement('div'), x=c[id], func=x[2], ex, pos=x[0]*offset;
                div.className=obj.controlclass;
                div.style.backgroundPosition='0px '+pos+'px';
                div.title=x[1];
          Severity: Major
          Found in public/javascripts/tinyeditor/tinyeditor.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if(this.ie){
            document.detachEvent('onmousemove',this.mv); document.detachEvent('onmouseup',this.sr)
        }else{
            document.removeEventListener('mousemove',this.mv,1); document.removeEventListener('mouseup',this.sr,1)
        }
            Severity: Major
            Found in public/javascripts/tinyeditor/tinyeditor.js and 1 other location - About 2 hrs to fix
            public/javascripts/tinyeditor/tinyeditor.js on lines 146..150

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 81.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if(this.ie){
            document.attachEvent('onmousemove',this.mv); document.attachEvent('onmouseup',this.sr)
        }else{
            document.addEventListener('mousemove',this.mv,1); document.addEventListener('mouseup',this.sr,1)
        }
            Severity: Major
            Found in public/javascripts/tinyeditor/tinyeditor.js and 1 other location - About 2 hrs to fix
            public/javascripts/tinyeditor/tinyeditor.js on lines 158..162

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 81.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status