Sign upLogin

camdub/Internships

View on GitHub
Star
public/myguide_asset/js/application.js

Summary

Maintainability
D
1 day
Test Coverage

Function setupGoals has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupGoals(){
    //initialize the all class
    $('.year1.progressbar, .year2.progressbar, .year3.progressbar, .year4.progressbar').addClass('all');
    //initialize the progress object with the default data
    //iterate through short term goals
Severity: Major
Found in public/myguide_asset/js/application.js - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                } else {
                //Put the code here for boxes that get unchecked
                //update the user's myguide data
            updateUserData(target.attr('task_id'), false);
                //update the progress bar for the given tag and given year
    Severity: Major
    Found in public/myguide_asset/js/application.js and 1 other location - About 4 hrs to fix
    public/myguide_asset/js/application.js on lines 99..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if(target.is(':checked')){
                //Put the code here for boxes that get checked
                //update the user's myguide data
            updateUserData(target.attr('task_id'), true);
                //update the prgress bar for the given tag and given year
    Severity: Major
    Found in public/myguide_asset/js/application.js and 1 other location - About 4 hrs to fix
    public/myguide_asset/js/application.js on lines 113..127

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                {
                'year1':     {'complete': 0,        'total':0},
                'year2':     {'complete': 0,        'total':0},
                'year3':     {'complete': 0,        'total':0},
                'year4':     {'complete': 0,        'total':0}
    Severity: Major
    Found in public/myguide_asset/js/application.js and 1 other location - About 1 hr to fix
    public/myguide_asset/js/application.js on lines 5..10

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        {
        'year1':     {'complete': 0,        'total':0},
        'year2':     {'complete': 0,        'total':0},
        'year3':     {'complete': 0,        'total':0},
        'year4':     {'complete': 0,        'total':0}
    Severity: Major
    Found in public/myguide_asset/js/application.js and 1 other location - About 1 hr to fix
    public/myguide_asset/js/application.js on lines 43..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status