camiloribeiro/quinoa

View on GitHub

Showing 3 of 3 total issues

Class Service has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Service

    attr_accessor :url, :content_type, :accept, :body, :response, :path, :authorization, :custom_headers, :time, :expectations, :assertions

    def initialize url
Severity: Minor
Found in lib/quinoa/service.rb - About 2 hrs to fix

    Method p_methods has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def p_methods method_name, url=nil
          meth = RestClient.method(method_name)
          begin
            if url == nil
              get_time {
    Severity: Minor
    Found in lib/quinoa/service.rb - About 1 hr to fix

      Method check_attribute? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def check_attribute? attribute, expected_value, comparator
            value = self.response.code if attribute == :status_code
            value = self.response.body if attribute == :body
            value = self.time.real if attribute == :response_time
      
      
      Severity: Minor
      Found in lib/quinoa/service.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language