Sign upLogin

camman3d/jerboa.js

View on GitHub
Star
src/html-manip.js

Summary

Maintainability
F
3 days
Test Coverage

Function createInfoBox has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function createInfoBox(spot, payload) {
    function changeColor(classList, currentClassName, newClassName) {
        if (classList.contains(currentClassName)) {classList.remove(currentClassName)};
        if (!classList.contains(newClassName)) {classList.add(newClassName)};
    }
Severity: Major
Found in src/html-manip.js - About 4 hrs to fix

    File html-manip.js has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { getGlobalOffset } from './positioning';
import { emit } from './events';
import state from './state';
import { isSafari } from './utils';
/*
    Severity: Minor
    Found in src/html-manip.js - About 2 hrs to fix

      Function addText has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function addText(container, payload, className) {
    let text = document.createElement('div');
    text.classList.add('feedback-text');
    if (className) {
        text.classList.add(className);
      Severity: Major
      Found in src/html-manip.js - About 2 hrs to fix

        Function createInfoBox has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        export function createInfoBox(spot, payload) {
    function changeColor(classList, currentClassName, newClassName) {
        if (classList.contains(currentClassName)) {classList.remove(currentClassName)};
        if (!classList.contains(newClassName)) {classList.add(newClassName)};
    }
        Severity: Minor
        Found in src/html-manip.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addBox has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function addBox(spot, toggled) {
    spot.addEventListener('click', event => {
        if (!state.active) {
            return;
        }
        Severity: Minor
        Found in src/html-manip.js - About 1 hr to fix

          Function addTextField has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function addTextField(boxContainer, label, containerClass) {
    let container = document.createElement('div');
    if (containerClass) {
        container.classList.add(containerClass)
    };
          Severity: Minor
          Found in src/html-manip.js - About 1 hr to fix

            Function addText has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function addText(container, payload, className) {
    let text = document.createElement('div');
    text.classList.add('feedback-text');
    if (className) {
        text.classList.add(className);
            Severity: Minor
            Found in src/html-manip.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                statusSelect.addEventListener('change', (e) => {
        payload.status = e.target.value;
        changeColor(spot.classList, `status-${currentStatus}`, `status-${payload.status}`)
        currentStatus = payload.status;
        emit('changeStatus', payload);
            Severity: Major
            Found in src/html-manip.js and 1 other location - About 2 hrs to fix
            src/html-manip.js on lines 409..414

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                ownerSelect.addEventListener('change', (e) => {
        payload.assigneeRole = e.target.value;
        changeColor(spot.classList, `owner-${currentAssigneeRole}`, `owner-${payload.assigneeRole}`)
        currentAssigneeRole = payload.assigneeRole;
        emit('changeOwner', payload);
            Severity: Major
            Found in src/html-manip.js and 1 other location - About 2 hrs to fix
            src/html-manip.js on lines 437..442

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for (let i = 0; i < ownerOptionsArr.length; i++) {
        let option = document.createElement('option');
        option.value = ownerOptions[ownerOptionsArr[i]];
        option.text = ownerOptionsArr[i];
        ownerSelect.appendChild(option);
            Severity: Major
            Found in src/html-manip.js and 1 other location - About 2 hrs to fix
            src/html-manip.js on lines 424..429

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for (let i = 0; i < statusOptionsArr.length; i++) {
        let option = document.createElement('option');
        option.value = statusOptions[statusOptionsArr[i]];
        option.text = statusOptionsArr[i];
        statusSelect.appendChild(option);
            Severity: Major
            Found in src/html-manip.js and 1 other location - About 2 hrs to fix
            src/html-manip.js on lines 396..401

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (payload.status && (payload.status !== defaultStatus)) {
        statusSelect.value = payload.status;
        changeColor(spot.classList, null, `status-${payload.status}`)
    } else {
        statusSelect.value = defaultStatus;
            Severity: Major
            Found in src/html-manip.js and 1 other location - About 2 hrs to fix
            src/html-manip.js on lines 403..408

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 79.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (payload.assigneeRole && (payload.assigneeRole !== defaultOwner)) {
        ownerSelect.value = payload.assigneeRole;
        changeColor(spot.classList, null, `owner-${payload.assigneeRole}`)
    } else {
        ownerSelect.value = defaultOwner;
            Severity: Major
            Found in src/html-manip.js and 1 other location - About 2 hrs to fix
            src/html-manip.js on lines 431..436

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 79.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    } else {
            const comment = generateComment(parts.textarea.value);
            parts.textarea.value = '';
            emit('cancelComment', comment);
            closeInfoBox();
            Severity: Minor
            Found in src/html-manip.js and 1 other location - About 50 mins to fix
            src/html-manip.js on lines 451..456

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                parts.cancel.addEventListener('click', () => {
        const comment = generateComment(parts.textarea.value);
        parts.textarea.value = '';
        emit('cancelComment', comment);
        closeInfoBox();
            Severity: Minor
            Found in src/html-manip.js and 1 other location - About 50 mins to fix
            src/html-manip.js on lines 468..473

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
            Open

            import { getGlobalOffset } from './positioning';
            Severity: Minor
            Found in src/html-manip.js by eslint

            For more information visit Source: http://eslint.org/docs/rules/

            There are no issues that match your filters.

            Category
            Status