Sign upLogin

carr/phone

View on GitHub
Star

Showing 4 of 4 total issues

Class Phone has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Phone
    module ClassAttributes
      attr_accessor :default_country_code
      attr_accessor :default_area_code
      attr_accessor :named_formats
Severity: Minor
Found in lib/phone.rb - About 2 hrs to fix

    Method split_to_parts has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.split_to_parts(string, options = {})
      country = detect_country(string)

      if country
        options[:country_code] = country.country_code
    Severity: Minor
    Found in lib/phone.rb - About 1 hr to fix

      Method split_to_parts has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.split_to_parts(string, options = {})
      country = detect_country(string)

      if country
        options[:country_code] = country.country_code
      Severity: Minor
      Found in lib/phone.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(*args)
      input = args.first.is_a?(Hash) ? args.first : args_to_hash(args)

      # set defaults
      input[:area_code] ||= self.default_area_code
      Severity: Minor
      Found in lib/phone.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language