cassell/Parm

View on GitHub

Showing 18 of 24 total issues

DataAccessObjectFactory has 57 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class DataAccessObjectFactory extends DatabaseProcessor implements TableInterface
{
    private $fields = array();
    private $conditional;
    private $joinClause = '';
Severity: Major
Found in src/DataAccessObjectFactory.php - About 1 day to fix

    File DataAccessObjectFactory.php has 414 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace Parm;
    
    use Parm\Binding\Binding;
    Severity: Minor
    Found in src/DataAccessObjectFactory.php - About 5 hrs to fix

      Function save has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
      Open

          public function save()
          {
              if (count($this->modifiedColumns) > 0) {
      
                  $sql = array();
      Severity: Minor
      Found in src/DataAccessObject.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      DataAccessObject has 26 functions (exceeds 20 allowed). Consider refactoring.
      Open

      abstract class DataAccessObject extends Row implements TableInterface
      {
          /**
           * Get the ID (Primary Key) of the object
           * @return mixed ID of the record in the database. null if a new record
      Severity: Minor
      Found in src/DataAccessObject.php - About 3 hrs to fix

        DatabaseProcessor has 23 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class DatabaseProcessor implements \Serializable
        {
            protected $sql = null;
            /**
             * @var \Doctrine\DBAL\Connection
        Severity: Minor
        Found in src/DatabaseProcessor.php - About 2 hrs to fix

          Function setSelectFields has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              public function setSelectFields($arrayOfFields)
              {
                  if ($arrayOfFields == null) {
                      throw new Exception\ErrorException('setSelectFields($arrayOfFields) $arrayOfFields can\'t be null.');
                  } elseif (func_num_args() == 1 && is_array($arrayOfFields)) {
          Severity: Minor
          Found in src/DataAccessObjectFactory.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getTemplatingDataFromSchema has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function getTemplatingDataFromSchema(TableSchema $schema)
              {
                  $columnData = [];
                  $fieldsPack = [];
                  $defaultValuePack = [];
          Severity: Minor
          Found in src/Generator/Generator.php - About 1 hr to fix

            Method save has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function save()
                {
                    if (count($this->modifiedColumns) > 0) {
            
                        $sql = array();
            Severity: Minor
            Found in src/DataAccessObject.php - About 1 hr to fix

              Function groupBy has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function groupBy($fieldOrArray)
                  {
                      if (func_num_args() > 1) {
                          // passed multiple fields $f->addGroupBy("first_name","last_name")
                          $this->groupBy(func_get_args());
              Severity: Minor
              Found in src/DataAccessObjectFactory.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function convertTimezone has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function convertTimezone($dateTime, $sourceTimezone, $destTimezone)
                  {
                      if ($dateTime === NULL) {
                          return NULL;
                      } elseif ($dateTime instanceof \DateTime) {
              Severity: Minor
              Found in src/DatabaseProcessor.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getSQL has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getSQL(\Parm\DataAccessObjectFactory $factory)
                  {
                      if (count($this->array) > 0) {
              
                          $escaped = array();
              Severity: Minor
              Found in src/Binding/InBinding.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getSQL has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getSQL(\Parm\DataAccessObjectFactory $factory)
                  {
                      if (count($this->array) > 0) {
              
                          $escaped = array();
              Severity: Minor
              Found in src/Binding/NotInBinding.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function __construct($tableName, $columnName, $type, $extra, $defaultValue, $primaryKey = false)
              Severity: Minor
              Found in src/Generator/Column.php - About 45 mins to fix

                Function __construct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function __construct(array $row = null, DataAccessObjectFactory $factory = null)
                    {
                        if ($row == null) {
                            $row = static::getDefaultRow();
                            $this->isNewObject = true;
                Severity: Minor
                Found in src/DataAccessObject.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method setupConnection has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public static function setupConnection($name, $databaseNameOnServer, $databaseUser, $databasePassword, $databaseHost)
                Severity: Minor
                Found in src/Config.php - About 35 mins to fix

                  Function generate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function generate()
                      {
                          $this->readyDestinationDirectory();
                  
                          $tableSchemas = (new SchemaGenerator($this->connection))->getTableSchemas();
                  Severity: Minor
                  Found in src/Generator/Generator.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function writeContentsToFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function writeContentsToFile($fileName, $contents)
                      {
                          if (file_exists($fileName) && !is_writable($fileName)) {
                              throw new \Parm\Exception\ErrorException('File is unwritable: ' . $fileName);
                          } elseif (@file_put_contents($fileName, $contents) !== FALSE) {
                  Severity: Minor
                  Found in src/Generator/Generator.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getObjects has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getObjects()
                      {
                          $data = array();
                  
                          if (static::getIdField() != null) {
                  Severity: Minor
                  Found in src/DataAccessObjectFactory.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language