Sign upLogin

catarse/catarse.js

View on GitHub
Star
legacy/src/c/user-subscription-box.js

Summary

Maintainability
D
2 days
Test Coverage

Function oninit has 163 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    oninit: function(vnode) {
        const subscription = vnode.attrs.subscription,
            displayModal = h.toggleProp(false, true),
            displayCancelModal = h.toggleProp(false, true),
            displayPaymentHistoryModal = h.toggleProp(false, true),
Severity: Major
Found in legacy/src/c/user-subscription-box.js - About 6 hrs to fix

    Function oninit has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        oninit: function(vnode) {
        const subscription = vnode.attrs.subscription,
            displayModal = h.toggleProp(false, true),
            displayCancelModal = h.toggleProp(false, true),
            displayPaymentHistoryModal = h.toggleProp(false, true),
    Severity: Minor
    Found in legacy/src/c/user-subscription-box.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File user-subscription-box.js has 290 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import m from 'mithril';
import prop from 'mithril/stream';
import _ from 'underscore';
import h from '../h';
import moment from 'moment';
    Severity: Minor
    Found in legacy/src/c/user-subscription-box.js - About 2 hrs to fix

      Function showLastSubscriptionVersionRewardTitleIfHasOne has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              const showLastSubscriptionVersionRewardTitleIfHasOne = () => {
            const is_active = subscription.status === 'active';
            const current_paid_subscription = subscription.current_paid_subscription;
            const current_reward_data = subscription.current_reward_data;
            const current_reward_id = subscription.current_reward_id;
      Severity: Minor
      Found in legacy/src/c/user-subscription-box.js - About 1 hr to fix

        Function view has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            view: function({ state }) {
        const subscription = state.subscription,
            project = subscription.project;

        return !_.isEmpty(subscription) && !_.isEmpty(subscription.project)
        Severity: Minor
        Found in legacy/src/c/user-subscription-box.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    const filterRewVM = catarse
                    .filtersVM({
                        id: 'eq',
                    })
                    .id(subscription.reward_external_id),
        Severity: Major
        Found in legacy/src/c/user-subscription-box.js and 2 other locations - About 1 hr to fix
        legacy/src/c/dashboard-subscription-card.js on lines 26..29
        legacy/src/c/user-subscription-box.js on lines 35..40

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                const filterProjVM = catarse
                .filtersVM({
                    project_id: 'eq',
                })
                .project_id(subscription.project_external_id),
        Severity: Major
        Found in legacy/src/c/user-subscription-box.js and 2 other locations - About 1 hr to fix
        legacy/src/c/dashboard-subscription-card.js on lines 26..29
        legacy/src/c/user-subscription-box.js on lines 63..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                      m(
                                  "a.btn.btn-edit.btn-inline.btn-small.w-button[href='javascript:void(0);']",
                                  {
                                      onclick: () => {
                                          state.displayModal.toggle();
        Severity: Minor
        Found in legacy/src/c/user-subscription-box.js and 1 other location - About 40 mins to fix
        legacy/src/c/user-contributed-box.js on lines 65..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status