Sign upLogin

catarse/catarse.js

View on GitHub
Star
legacy/src/root/admin-balance-tranfers.js

Summary

Maintainability
F
4 days
Test Coverage

Function oninit has 280 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    oninit: function(vnode) {
        const listVM = balanceTransferListVM,
            filterVM = balanceTransferFilterVM(),
            authorizedListVM = balanceTransferListVM,
            authorizedFilterVM = balanceTransferFilterVM(),
Severity: Major
Found in legacy/src/root/admin-balance-tranfers.js - About 1 day to fix

    File admin-balance-tranfers.js has 340 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import m from 'mithril';
import prop from 'mithril/stream';
import h from '../h';
import _ from 'underscore';
import balanceTransferListVM from '../vms/balance-transfer-list-vm';
    Severity: Minor
    Found in legacy/src/root/admin-balance-tranfers.js - About 4 hrs to fix

      Function generateWrapperModal has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  generateWrapperModal = (customAttrs) => {
                const wrapper = {
                    view: function({state, attrs}) {
                        actionMenuToggle(false);
                        return m('', [
      Severity: Major
      Found in legacy/src/root/admin-balance-tranfers.js - About 2 hrs to fix

        Function oninit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            oninit: function(vnode) {
        const listVM = balanceTransferListVM,
            filterVM = balanceTransferFilterVM(),
            authorizedListVM = balanceTransferListVM,
            authorizedFilterVM = balanceTransferFilterVM(),
        Severity: Minor
        Found in legacy/src/root/admin-balance-tranfers.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                    submit = () => {
                error(false);
                listVM.firstPage(filterVM.parameters()).then(_ => m.redraw(), (serverError) => {
                    error(serverError.message);
                    m.redraw();
        Severity: Major
        Found in legacy/src/root/admin-balance-tranfers.js and 2 other locations - About 2 hrs to fix
        legacy/src/root/admin-contributions.js on lines 123..130
        legacy/src/root/admin-subscriptions.js on lines 60..67

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 85.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                        m.request({
                    method: 'POST',
                    url: '/admin/balance_transfers/batch_reject',
                    data: {
                        transfer_ids: _.uniq(_.map(selectedItemsIDs(), s => s.id))
        Severity: Major
        Found in legacy/src/root/admin-balance-tranfers.js and 2 other locations - About 1 hr to fix
        legacy/src/root/admin-balance-tranfers.js on lines 187..199
        legacy/src/root/admin-balance-tranfers.js on lines 202..215

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                        m.request({
                    method: 'POST',
                    url: '/admin/balance_transfers/batch_manual',
                    data: {
                        transfer_ids: _.uniq(_.map(selectedItemsIDs(), s => s.id))
        Severity: Major
        Found in legacy/src/root/admin-balance-tranfers.js and 2 other locations - About 1 hr to fix
        legacy/src/root/admin-balance-tranfers.js on lines 202..215
        legacy/src/root/admin-balance-tranfers.js on lines 234..246

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                        m.request({
                    method: 'POST',
                    url: '/admin/balance_transfers/batch_approve',
                    data: {
                        transfer_ids: _.uniq(_.map(selectedItemsIDs(), s => s.id))
        Severity: Major
        Found in legacy/src/root/admin-balance-tranfers.js and 2 other locations - About 1 hr to fix
        legacy/src/root/admin-balance-tranfers.js on lines 187..199
        legacy/src/root/admin-balance-tranfers.js on lines 234..246

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

                    (state.displayManualModal() ? m(modalBox, {
                displayModal: state.displayManualModal,
                content: state.generateWrapperModal({
                    modalTitle: 'Transferencia manual de saques',
                    ctaText: 'Aprovar',
        Severity: Major
        Found in legacy/src/root/admin-balance-tranfers.js and 4 other locations - About 1 hr to fix
        legacy/src/root/admin-balance-tranfers.js on lines 343..351
        legacy/src/root/admin-balance-tranfers.js on lines 361..369
        legacy/src/root/admin-contributions.js on lines 273..281
        legacy/src/root/admin-subscriptions.js on lines 211..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 71.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

                    (state.displayRejectModal() ? m(modalBox, {
                displayModal: state.displayRejectModal,
                content: state.generateWrapperModal({
                    modalTitle: 'Rejeitar saques',
                    ctaText: 'Rejeitar',
        Severity: Major
        Found in legacy/src/root/admin-balance-tranfers.js and 4 other locations - About 1 hr to fix
        legacy/src/root/admin-balance-tranfers.js on lines 343..351
        legacy/src/root/admin-balance-tranfers.js on lines 352..360
        legacy/src/root/admin-contributions.js on lines 273..281
        legacy/src/root/admin-subscriptions.js on lines 211..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 71.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

                    (state.displayApprovalModal() ? m(modalBox, {
                displayModal: state.displayApprovalModal,
                content: state.generateWrapperModal({
                    modalTitle: 'Aprovar saques',
                    ctaText: 'Aprovar',
        Severity: Major
        Found in legacy/src/root/admin-balance-tranfers.js and 4 other locations - About 1 hr to fix
        legacy/src/root/admin-balance-tranfers.js on lines 352..360
        legacy/src/root/admin-balance-tranfers.js on lines 361..369
        legacy/src/root/admin-contributions.js on lines 273..281
        legacy/src/root/admin-subscriptions.js on lines 211..219

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 71.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                                        m('.w-row.u-margintop-40', [
                                    m('.w-col.w-col-1'),
                                    m('.w-col.w-col-5',
                                        m('a.btn.btn-medium.w-button', {
                                            onclick: attrs.onClickCallback
        Severity: Major
        Found in legacy/src/root/admin-balance-tranfers.js and 2 other locations - About 1 hr to fix
        legacy/src/root/admin-contributions.js on lines 179..192
        legacy/src/root/admin-subscriptions.js on lines 116..129

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                            m('.w-col.w-col-3',
                                        `R$ ${h.formatNumber(_.reduce(selectedItemsIDs(), (t, i) => t + i.amount, 0), 2, 3)}`),
        Severity: Minor
        Found in legacy/src/root/admin-balance-tranfers.js and 1 other location - About 50 mins to fix
        legacy/src/root/admin-contributions.js on lines 177..177

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status